[GitHub] youngyjd commented on a change in pull request #5848: fix sqlab progress bar and status inconsistency

[GitBox <gi...@apache.org>]

youngyjd commented on a change in pull request #5848: fix sqlab progress bar and status inconsistency
URL: https://github.com/apache/incubator-superset/pull/5848#discussion_r216505165
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/ResultSet.jsx
 ##########
 @@ -200,7 +200,7 @@ export default class ResultSet extends React.PureComponent {
     }
     let progressBar;
     let trackingUrl;
-    if (query.progress > 0 && query.state === 'running') {
+    if (query.progress > 0) {
 
 Review comment:
   yeap. In the next round of rerendering `SqlLab` app, it will disappear. https://github.com/apache/incubator-superset/blob/cb92739c46355c3217b33297cbcce8801f5768aa/superset/assets/src/SqlLab/components/ResultSet.jsx#L165-#L189

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org