Re: [PR] MINIFICPP-2260 Fix OpenCV extension build failure on macOS [nifi-minifi-cpp]

["martinzink (via GitHub)" <gi...@apache.org>]

martinzink commented on code in PR #1694:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1694#discussion_r1380397301


##########
cmake/BundledOpenCV.cmake:
##########
@@ -210,5 +210,7 @@ function(use_bundled_opencv SOURCE_DIR BINARY_DIR)
 
     add_library(OPENCV::libopencv INTERFACE IMPORTED)
     target_link_libraries(OPENCV::libopencv INTERFACE OPENCV::libopencv-flann OPENCV::libopencv-dnn OPENCV::libopencv-objdetect OPENCV::libopencv-core OPENCV::libopencv-gapi OPENCV::libopencv-imgcodecs OPENCV::libopencv-calib3d OPENCV::libopencv-imgproc OPENCV::libopencv-photo OPENCV::libopencv-videoio OPENCV::libopencv-video OPENCV::libopencv-stitching OPENCV::libopencv-features2d)
-
+    if (APPLE)
+        target_link_libraries(OPENCV::libopencv INTERFACE "-framework AVFoundation" "-framework CoreFoundation" "-framework CoreGraphics" "-framework CoreMedia" "-framework CoreVideo" "-framework Foundation" "-framework OpenCL" "-framework Accelerate")

Review Comment:
   Afaik OpenCV handles this, I think we need this manual work due to our convoluted way of integrating opencv, I think we should be able to switch to fetchcontent but it wasnt trivial. 
   I'll create a new Jira and investigate how painful that would be.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org