You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Chia-Ping Tsai (Jira)" <ji...@apache.org> on 2024/06/12 03:49:00 UTC

[jira] [Commented] (KAFKA-16643) Add ModifierOrder checkstyle rule

    [ https://issues.apache.org/jira/browse/KAFKA-16643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854235#comment-17854235 ] 

Chia-Ping Tsai commented on KAFKA-16643:
----------------------------------------

{quote}
this is for the modifiers on variables/methods etc (static final abstract etc)
{quote}

just noticed that I misunderstand this jira, sorry :(

I will review the PR filed by [~gongxuanzhang].



> Add ModifierOrder checkstyle rule
> ---------------------------------
>
>                 Key: KAFKA-16643
>                 URL: https://issues.apache.org/jira/browse/KAFKA-16643
>             Project: Kafka
>          Issue Type: Task
>          Components: build
>            Reporter: Greg Harris
>            Priority: Minor
>
> Checkstyle offers the ModifierOrder rule: [https://checkstyle.sourceforge.io/checks/modifier/modifierorder.html] that Kafka violates in a lot of places. We should decide if this is a checkstyle rule we should be following or not, and potentially enable it moving forward.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)