You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/10 08:25:57 UTC

[GitHub] [spark] karolchmist commented on pull request #28545: [SPARK-30090][SHELL] Adapt Spark REPL to Scala 2.13

karolchmist commented on pull request #28545:
URL: https://github.com/apache/spark/pull/28545#issuecomment-690077928


   Hello @srowen , for me the PR is ready to be reviewed.
   
   I extracted a Scala 2.12/2.13 specific code to separate directories, as the interface of `ILoop` changed. I also had to extract some fragments of tests for this reason. I put them in new files, putting a `2` infix in the name, for example `Repl2Suite.scala` -> `ReplSuite.scala`, to avoid a name collision. I would gladly change the name if you have a better one...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org