You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/13 00:18:49 UTC
[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request
#4431: Misc fix for controller tests
mcvsubbu commented on a change in pull request #4431: Misc fix for controller tests
URL: https://github.com/apache/incubator-pinot/pull/4431#discussion_r303182258
##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1087,9 +1086,6 @@ public void addTable(@Nonnull TableConfig tableConfig)
// lets add table configs
ZKMetadataProvider.setOfflineTableConfig(_propertyStore, tableNameWithType, tableConfig.toZNRecord());
- _propertyStore.create(ZKMetadataProvider.constructPropertyStorePathForResource(tableNameWithType),
Review comment:
yeah, and all the tests passed too!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org