[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3600: [SPARK][K8S] On k8s with deploy cluster mode case, spark sql engine should not set web ui port to 0

[GitBox <gi...@apache.org>]

pan3793 commented on code in PR #3600:
URL: https://github.com/apache/incubator-kyuubi/pull/3600#discussion_r991023742


##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala:
##########
@@ -171,6 +170,11 @@ object SparkSQLEngine extends Logging {
       kyuubiConf.setIfMissing(FRONTEND_CONNECTION_URL_USE_HOSTNAME, false)
     }
 
+    // set web ui port 0 when no deploy k8s cluster mode

Review Comment:
   The comment is redundant since the code is clear enough to explain what we are doing here, the really helpful comments should explain WHY we do that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org