[GitHub] [skywalking] wu-sheng commented on issue #5101: It's hard to distinguish business exception and other errors with Error status filter on the trace page

[GitBox <gi...@apache.org>]

wu-sheng commented on issue #5101:
URL: https://github.com/apache/skywalking/issues/5101#issuecomment-658627474


   > It 's common to use global exception handler in spring. We can throw the all business exceptions in controller, and catch it by a custom ExceptionHandler with ControllerAdvice annotation.
   
   I can't agree it is common or right. Controlling the workflow by exception is rude and low-performance. 
   But if you do that, you have to change the source codes on your own. SkyWalking wouldn't take that responsibility because if we do so, we have to check every exception and iterate its parent, it will burn the agent in heavy traffic systems. If you know where to do the filter, change the codes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org