You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "Croway (via GitHub)" <gi...@apache.org> on 2026/06/04 17:42:49 UTC
[PR] CAMEL-23682: expose common UndertowOptions on UndertowHostOptions [camel]
Croway opened a new pull request, #23773:
URL: https://github.com/apache/camel/pull/23773
## Summary
- Add 8 new typed fields to `UndertowHostOptions` (`maxEntitySize`, `multipartMaxEntitySize`, `maxHeaderSize`, `noRequestTimeout`, `idleTimeout`, `requestParseTimeout`, `maxParameters`, `maxHeaders`) following the existing `http2Enabled` pattern
- Wire each option in `DefaultUndertowHost` via `builder.setServerOption()`
- Document all host options (existing and new) in `undertow-component.adoc`
- Add integration test for `maxEntitySize`
## Test plan
- [x] `UndertowMaxEntitySizeTest` — verifies requests within and exceeding the configured limit
- [x] `UndertowHttp2Test` — existing test still passes (no regression)
- [x] Full module build: `cd components/camel-undertow && mvn verify`
_Claude Code on behalf of Federico Mariani_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23682: expose common UndertowOptions on UndertowHostOptions [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23773:
URL: https://github.com/apache/camel/pull/23773#issuecomment-4624815352
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `components/camel-undertow`
> :information_source: Dependent modules were not tested because the total number of affected modules exceeded the threshold (50). Use the `test-dependents` label to force testing all dependents.
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/26969071177)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23682: expose common UndertowOptions on UndertowHostOptions [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23773:
URL: https://github.com/apache/camel/pull/23773#issuecomment-4624706174
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23682: expose common UndertowOptions on UndertowHostOptions [camel]
Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway merged PR #23773:
URL: https://github.com/apache/camel/pull/23773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23682: expose common UndertowOptions on UndertowHostOptions [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #23773:
URL: https://github.com/apache/camel/pull/23773#issuecomment-4624950016
> > Clean, well-scoped enhancement. All 8 new options follow the existing `http2Enabled` pattern exactly — nullable fields with null checks before `setServerOption()`. Documentation table covers all host options (existing + new) with a properties configuration example. Test covers `maxEntitySize` for both within-limit and exceeding-limit cases.
> > Minor: only `maxEntitySize` has a test — the other 7 options follow the identical pattern so the risk is low, but a test for one more option (e.g., `maxHeaders`) would strengthen confidence.
> > This review does not replace specialized AI review tools (CodeRabbit, Sourcery) or static analysis (SonarCloud).
> > _This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying._
>
> Yeah, I tested only one configuration on puspose, anyway, they are just set on an object, nothing fancy
Yeah we dont escape the eyes from the AI ;)
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23682: expose common UndertowOptions on UndertowHostOptions [camel]
Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway commented on PR #23773:
URL: https://github.com/apache/camel/pull/23773#issuecomment-4624918035
> Clean, well-scoped enhancement. All 8 new options follow the existing `http2Enabled` pattern exactly — nullable fields with null checks before `setServerOption()`. Documentation table covers all host options (existing + new) with a properties configuration example. Test covers `maxEntitySize` for both within-limit and exceeding-limit cases.
>
> Minor: only `maxEntitySize` has a test — the other 7 options follow the identical pattern so the risk is low, but a test for one more option (e.g., `maxHeaders`) would strengthen confidence.
>
> This review does not replace specialized AI review tools (CodeRabbit, Sourcery) or static analysis (SonarCloud).
>
> _This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying._
Yeah, I tested only one configuration on puspose, anyway, they are just set on an object, nothing fancy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org