You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/03/10 00:00:26 UTC

[GitHub] michellethomas commented on issue #4590: Removing escape_sql so we dont double escape

michellethomas commented on issue #4590: Removing escape_sql so we dont double escape
URL: https://github.com/apache/incubator-superset/pull/4590#issuecomment-371979610
 
 
   @mistercrunch we are a little unsure what would have caused this regression, as nothing seems to have changed in the related code recently. It looks like in sqlalchemy 1.2 they did some work to their autoescape feature. Maybe our sqlalchemy upgrade caused this issue, but it's a little unclear. Any thoughts on why we might be seeing double % escaping? Anything else we should be aware of in removing this part of the code?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services