You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by vbmudalige <gi...@git.apache.org> on 2018/10/02 18:22:17 UTC
[GitHub] hadoop pull request #421: YARN-8788. mvn package -Pyarn-ui fails on JDK9
GitHub user vbmudalige opened a pull request:
https://github.com/apache/hadoop/pull/421
YARN-8788. mvn package -Pyarn-ui fails on JDK9
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vbmudalige/hadoop YARN-8788
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hadoop/pull/421.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #421
----
commit f52513d0c1b304ebb608bd1b828d109d03d8a19f
Author: Vidura Mudalige <vi...@...>
Date: 2018-10-02T18:03:43Z
YARN-8788. mvn package -Pyarn-ui fails on JDK9
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] hadoop pull request #421: YARN-8788. mvn package -Pyarn-ui fails on JDK9
Posted by vbmudalige <gi...@git.apache.org>.
Github user vbmudalige commented on a diff in the pull request:
https://github.com/apache/hadoop/pull/421#discussion_r222198499
--- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/pom.xml ---
@@ -202,6 +202,13 @@
<groupId>ro.isdc.wro4j</groupId>
<artifactId>wro4j-maven-plugin</artifactId>
<version>1.7.9</version>
+ <dependencies>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-core</artifactId>
+ <version>2.18.0</version>
+ </dependency>
+ </dependencies>
--- End diff --
@aajisaka, I made the changes. Please review.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] hadoop pull request #421: YARN-8788. mvn package -Pyarn-ui fails on JDK9
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/hadoop/pull/421
---
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] hadoop pull request #421: YARN-8788. mvn package -Pyarn-ui fails on JDK9
Posted by aajisaka <gi...@git.apache.org>.
Github user aajisaka commented on a diff in the pull request:
https://github.com/apache/hadoop/pull/421#discussion_r222153880
--- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/pom.xml ---
@@ -202,6 +202,13 @@
<groupId>ro.isdc.wro4j</groupId>
<artifactId>wro4j-maven-plugin</artifactId>
<version>1.7.9</version>
+ <dependencies>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-core</artifactId>
+ <version>2.18.0</version>
+ </dependency>
+ </dependencies>
--- End diff --
Thanks @vbmudalige for the pull request.
* Would you comment that "TODO: remove this dependency after upgrading wro4j-maven-plugin to 1.8.1 or later"?
* Would you remove 2 whitespaces from the indents?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org