You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "platoneko (via GitHub)" <gi...@apache.org> on 2023/02/20 07:28:58 UTC

[GitHub] [doris] platoneko commented on a diff in pull request #16891: [improvement](scan) separate scanner into local and remote scanner pool

platoneko commented on code in PR #16891:
URL: https://github.com/apache/doris/pull/16891#discussion_r1111568305


##########
be/src/vec/exec/scan/new_olap_scanner.cpp:
##########
@@ -385,6 +385,23 @@ Status NewOlapScanner::_init_return_columns() {
     return Status::OK();
 }
 
+doris::TabletStorageType NewOlapScanner::get_storage_type() {
+    int local_reader = 0;
+    for (const auto& reader : _tablet_reader_params.rs_readers) {
+        if (reader->rowset()->rowset_meta()->resource_id().empty()) {

Review Comment:
   Can directly use `rowset->is_local` here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org