You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/07/14 02:02:52 UTC

[PR] Refactor MCP workflow and metadata boundaries [shardingsphere]

terrymanu opened a new pull request, #39089:
URL: https://github.com/apache/shardingsphere/pull/39089

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor MCP workflow and metadata boundaries [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39089:
URL: https://github.com/apache/shardingsphere/pull/39089


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor MCP workflow and metadata boundaries [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39089:
URL: https://github.com/apache/shardingsphere/pull/39089#issuecomment-4964930597

   ### Summary
   
   **Review Result: Mergeable**
   
   Reason: This result applies to the code scope only. No blocking issues were found in the latest PR implementation, tests, behavior, or scope. CI not reviewed by request.
   
   ### Evidence
   
   - The 155 files from GitHub `/pulls/39089/files` exactly match the local triple-dot diff: 81 production files and 74 test files.
   - JDBC owned-connection and borrowed transaction-connection responsibilities remain explicit. Exception translation and transaction capability checks have not regressed.
   - The workflow state, recovery payload, argument binding, metadata response, and completion action refactoring preserves the existing fields, defaults, and call order.
   - Workflow snapshots share only immutable elements, while their collections remain independent.
   - All repository call sites were migrated for the public symbol changes, and the previous MCP APIs have not appeared in a release tag.
   - The current base changed 10 files after the merge base, with no overlap with this PR.
   - The final adversarial review found no additional independent issues.
   
   ### Review Details
   
   - **Review Focus:** Code Correctness Review. CI not reviewed by request.
   - **Reviewed Scope:** `mcp/api`, `mcp/core`, `mcp/support`, `mcp/bootstrap`, `mcp/features`, and `test/e2e/mcp`. Head SHA: `f0ccde84f8e3b80c19125da2f6f5fa38cb8443e9`; merge-base SHA: `25252d64b4adea58517d395c5f55d59ce2efd76c`. The local file list matched the GitHub file list.
   - **Not Reviewed Scope:** GitHub Actions, check runs, and workflow logs. Runtime E2E scenarios requiring Docker or an external LLM were skipped by configuration.
   - **Verification:** `./mvnw spotless:check -Pcheck -T1C`, exit `0`; `./mvnw checkstyle:check -Pcheck -T1C`, exit `0`; tests for nine MCP-related modules, exit `0`; `test/e2e/mcp` tests, exit `0`, with 469 tests discovered, 365 executed successfully, and 104 environment-dependent scenarios skipped.
   - **Release Note / User Docs:** Not required. This PR does not change configuration keys, released protocol semantics, or user migration procedures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org