You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:36:27 UTC
[GitHub] [pulsar-client-go] abatilo opened a new pull request #273: WIP Create tenants client for Admin API
abatilo opened a new pull request #273:
URL: https://github.com/apache/pulsar-client-go/pull/273
### Motivation
The purpose for this PR is to start a conversation about implementing the Pulsar Admin API in this Go client, and to discuss how the client should be structured and exposed.
### Modifications
Created a bare bones implementation for a single API request for listing tenants.
### Considerations/Talking points
Do we want the admin API client to be in its own package? Are we happy with `pulsar.NewAdminClient()` or should we create a nested package for something like `import ...pulsar/admin` and then `admin.NewClient()`?
This WIP implementation is **heavily** inspired by:
https://github.com/google/go-github
As such, there's one general client which will contain references to different "Services" which encompass the various parts of the API.
Additionally, do we want to follow the file structure of `go-github`? A flat file structure with various parts of the API split across different files.
What kind of testing do we consider required vs acceptable for having this Admin API?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy commented on pull request #273: WIP/RFC Create tenants client for Admin API
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #273:
URL: https://github.com/apache/pulsar-client-go/pull/273#issuecomment-660406151
> Closing since it seems like there might be some action with `pulsarctl` contributions instead.
Cool, welcome
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] liangyuanpeng commented on pull request #273: WIP/RFC Create tenants client for Admin API
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on pull request #273:
URL: https://github.com/apache/pulsar-client-go/pull/273#issuecomment-644527481
@wolfstudy
I think these are two application scenarios , actually I am also looking for client-go admin api for my application.
I hope to be able to use pulsar admin api in my golang application. (Restful API can do it, but it would be great if client-go implemented this part) :smile:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] abatilo commented on pull request #273: WIP/RFC Create tenants client for Admin API
Posted by GitBox <gi...@apache.org>.
abatilo commented on pull request #273:
URL: https://github.com/apache/pulsar-client-go/pull/273#issuecomment-641331130
@merlimat I would love to start this conversation and help push forward on implementing the Admin API into this project. Could I get some thoughts? I'm new to this project so I'm not sure who else to tag but you responded in Slack :sweat_smile:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy commented on pull request #273: WIP/RFC Create tenants client for Admin API
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #273:
URL: https://github.com/apache/pulsar-client-go/pull/273#issuecomment-646429074
> @wolfstudy
> I think these are two application scenarios , actually I am also looking for client-go admin api for my application.
>
> I hope to be able to use pulsar admin api in my golang application. (Restful API can do it, but it would be great if client-go implemented this part) 😄
Yes, I know. In pulsarctl, we currently support `webServiceUrl(:8080)` related functions, we may need to support `brokerServiceUrl(:6650)` related functions in pulsarctl. Because pulsarctl has implemented a complete framework about Admin CLI, it will be easier to implement in pulsarctl. Of course, we may also need to do something in go-client to support it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] abatilo closed pull request #273: WIP/RFC Create tenants client for Admin API
Posted by GitBox <gi...@apache.org>.
abatilo closed pull request #273:
URL: https://github.com/apache/pulsar-client-go/pull/273
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy commented on pull request #273: WIP/RFC Create tenants client for Admin API
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #273:
URL: https://github.com/apache/pulsar-client-go/pull/273#issuecomment-641685751
@abatilo we have created a Golang Admin CLI repo in https://github.com/streamnative/pulsarctl. If possible, we can contribute this repo back. If you are interested in this, you are welcome to continue to contribute based on the `pulsarctl` repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] abatilo commented on pull request #273: WIP/RFC Create tenants client for Admin API
Posted by GitBox <gi...@apache.org>.
abatilo commented on pull request #273:
URL: https://github.com/apache/pulsar-client-go/pull/273#issuecomment-660298960
Closing since it seems like there might be some action with `pulsarctl` contributions instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org