[jira] [Commented] (CB-11023) plugin.xml should be able to add attribute to an existing element in AndroidManifest.xml

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254024#comment-15254024 ] 

ASF GitHub Bot commented on CB-11023:
-------------------------------------

GitHub user ktop opened a pull request:

    https://github.com/apache/cordova-lib/pull/432

    CB-11023 Add attribute through config-file tag

    Add functionality to be able to add attributes to xml files through config-file tag. 
    
    Syntax:
    Able to add multiple attributes to multiple elements at once (only to direct children of the parent). 
    ```
    <config-file target="AndroidManifest.xml" parent="/manifest" attr="true">
            <application android:name="MyApplication" android:isGame="true" />
            <uses-sdk android:maxSdkVersion="22" />
    </config-file>
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ktop/cordova-lib cb-11023

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/432.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #432
    
----
commit aa3427ce38ef0bd2e2ac71e5d56d7d9d0dc6b15c
Author: Karen Tran <kt...@gmail.com>
Date:   2016-04-22T14:05:12Z

    CB-11023 Add attribute through config-file tag
    
    Add back comment and fix format

----


> plugin.xml should be able to add attribute to an existing element in AndroidManifest.xml
> ----------------------------------------------------------------------------------------
>
>                 Key: CB-11023
>                 URL: https://issues.apache.org/jira/browse/CB-11023
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CLI, Plugman
>            Reporter: Carlos Santana
>
> We have a need for a plugin we develop to add the attribute android:name to the <application> element to be able to point to a Class that tracks app sessions for analytics.
> plugin.xml only support via <config-file> only to add elements to AndroidManfist.xml this request is to add an enhancement to also handle adding an attribute to an existing element.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org