You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/30 12:39:26 UTC
[GitHub] [airflow] turbaszek opened a new pull request #8011: Rename
CloudBaseHook to GoogleBaseHook and move it to google.common
turbaszek opened a new pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common
URL: https://github.com/apache/airflow/pull/8011
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] turbaszek commented on a change in pull request #8011:
Rename CloudBaseHook to GoogleBaseHook and move it to google.common
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common
URL: https://github.com/apache/airflow/pull/8011#discussion_r400198758
##########
File path: airflow/providers/google/cloud/hooks/discovery_api.py
##########
@@ -23,10 +23,10 @@
from googleapiclient.discovery import Resource, build
-from airflow.providers.google.cloud.hooks.base import CloudBaseHook
+from airflow.providers.google.common.hooks.base import GoogleBaseHook
Review comment:
I think so, good catch! @potiuk WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8011:
Rename CloudBaseHook to GoogleBaseHook and move it to google.common
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common
URL: https://github.com/apache/airflow/pull/8011#discussion_r400558577
##########
File path: airflow/providers/google/cloud/hooks/discovery_api.py
##########
@@ -23,10 +23,10 @@
from googleapiclient.discovery import Resource, build
-from airflow.providers.google.cloud.hooks.base import CloudBaseHook
+from airflow.providers.google.common.hooks.base import GoogleBaseHook
Review comment:
Thanks for doing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8011:
Rename CloudBaseHook to GoogleBaseHook and move it to google.common
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common
URL: https://github.com/apache/airflow/pull/8011#discussion_r400558131
##########
File path: airflow/providers/google/cloud/hooks/discovery_api.py
##########
@@ -23,10 +23,10 @@
from googleapiclient.discovery import Resource, build
-from airflow.providers.google.cloud.hooks.base import CloudBaseHook
+from airflow.providers.google.common.hooks.base import GoogleBaseHook
Review comment:
I will do it in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8011:
Rename CloudBaseHook to GoogleBaseHook and move it to google.common
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common
URL: https://github.com/apache/airflow/pull/8011#discussion_r400558131
##########
File path: airflow/providers/google/cloud/hooks/discovery_api.py
##########
@@ -23,10 +23,10 @@
from googleapiclient.discovery import Resource, build
-from airflow.providers.google.cloud.hooks.base import CloudBaseHook
+from airflow.providers.google.common.hooks.base import GoogleBaseHook
Review comment:
I will do it in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8011:
Rename CloudBaseHook to GoogleBaseHook and move it to google.common
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common
URL: https://github.com/apache/airflow/pull/8011#discussion_r400562737
##########
File path: airflow/providers/google/cloud/hooks/automl.py
##########
@@ -29,10 +29,10 @@
ImageObjectDetectionModelDeploymentMetadata, InputConfig, Model, Operation, PredictResponse, TableSpec,
)
-from airflow.providers.google.cloud.hooks.base import CloudBaseHook
+from airflow.providers.google.common.hooks.base import GoogleBaseHook
Review comment:
```suggestion
from airflow.providers.google.common.hooks.base_google import GoogleBaseHook
```
We agreed to such a convention in the case of AWS. In the case of Google, we should also use it. I will add a commit to this branch, which corrects it, and then from this branch I will start new PR, which will correct other errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #8011: Rename CloudBaseHook to
GoogleBaseHook and move it to google.common
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common
URL: https://github.com/apache/airflow/pull/8011#issuecomment-606168160
Hi. Travis is sad. This is a blocker for me because I would like to take care of the latest improvements. in the package/class name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8011:
Rename CloudBaseHook to GoogleBaseHook and move it to google.common
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common
URL: https://github.com/apache/airflow/pull/8011#discussion_r400187606
##########
File path: airflow/providers/google/cloud/hooks/discovery_api.py
##########
@@ -23,10 +23,10 @@
from googleapiclient.discovery import Resource, build
-from airflow.providers.google.cloud.hooks.base import CloudBaseHook
+from airflow.providers.google.common.hooks.base import GoogleBaseHook
Review comment:
Should we move this hook to common package?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #8011: Rename CloudBaseHook to
GoogleBaseHook and move it to google.common
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common
URL: https://github.com/apache/airflow/pull/8011
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #8011:
Rename CloudBaseHook to GoogleBaseHook and move it to google.common
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #8011: Rename CloudBaseHook to GoogleBaseHook and move it to google.common
URL: https://github.com/apache/airflow/pull/8011#discussion_r400562737
##########
File path: airflow/providers/google/cloud/hooks/automl.py
##########
@@ -29,10 +29,10 @@
ImageObjectDetectionModelDeploymentMetadata, InputConfig, Model, Operation, PredictResponse, TableSpec,
)
-from airflow.providers.google.cloud.hooks.base import CloudBaseHook
+from airflow.providers.google.common.hooks.base import GoogleBaseHook
Review comment:
```suggestion
from airflow.providers.google.common.hooks.base_google import GoogleBaseHook
```
We agreed to such a convention in the case of AWS. In the case of Google, we should also use it. I will add a commit to this branch, which corrects it. In next step, I will start new PR starting from this branch, which will correct other errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services