You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/22 19:58:39 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #5835: Python: Remove version modifier
Fokko opened a new pull request, #5835:
URL: https://github.com/apache/iceberg/pull/5835
This way we can just use the code as is when releasing, and we don't have to remove the modifier afterward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] danielcweeks commented on a diff in pull request #5835: Python: Remove version modifier
Posted by GitBox <gi...@apache.org>.
danielcweeks commented on code in PR #5835:
URL: https://github.com/apache/iceberg/pull/5835#discussion_r978832471
##########
python/pyproject.toml:
##########
@@ -17,7 +17,7 @@
[tool.poetry]
name = "pyiceberg"
-version = "0.1.0.dev0"
+version = "0.1.0"
Review Comment:
I'm not really familiar with how Poetry does versioning, but if we push this to master, doesn't that make the baseline pinned to `0.1.0` for all build artifacts until it's updated? On the java side, I think we don't explicitly checkin a release version number. Feels like we should only have a release version for the actual release build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko merged pull request #5835: Python: Remove version modifier
Posted by GitBox <gi...@apache.org>.
Fokko merged PR #5835:
URL: https://github.com/apache/iceberg/pull/5835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #5835: Python: Remove version modifier
Posted by GitBox <gi...@apache.org>.
Fokko commented on code in PR #5835:
URL: https://github.com/apache/iceberg/pull/5835#discussion_r978872508
##########
python/pyproject.toml:
##########
@@ -17,7 +17,7 @@
[tool.poetry]
name = "pyiceberg"
-version = "0.1.0.dev0"
+version = "0.1.0"
Review Comment:
We have a SNAPSHOT version for Java, right? My idea was to set it to `0.1.0` so we can release the code-base as is, and we don't have to update versions after the RC is accepted. After the release, I'll bump it to `0.2.0` on master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org