[GitHub] [pinot] walterddr commented on a diff in pull request #10933: Fixing table name extraction for lateral join queries

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10933:
URL: https://github.com/apache/pinot/pull/10933#discussion_r1235942553


##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java:
##########
@@ -180,6 +180,8 @@ public static List<String> extractTableNamesFromNode(SqlNode sqlNode) {
         SqlNode firstOperand = ((SqlBasicCall) sqlNode).getOperandList().get(0);
         if (firstOperand instanceof SqlSelect) {
           tableNames.addAll(extractTableNamesFromNode(firstOperand));
+        } else if (firstOperand instanceof SqlBasicCall) {
+          tableNames.addAll(extractTableNamesFromNode(((SqlBasicCall) firstOperand).getOperandList().get(0)));

Review Comment:
   TODO: this util is going away. will merge then remove all together



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org