You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/21 12:26:31 UTC
[GitHub] [flink] dawidwys opened a new pull request #10916:
[FLINK-15684][docs] Add taskmanager.memory.flink.size to common options
dawidwys opened a new pull request #10916: [FLINK-15684][docs] Add taskmanager.memory.flink.size to common options
URL: https://github.com/apache/flink/pull/10916
## What is the purpose of the change
Add `taskmanager.memory.flink.size` to common options.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10916:
[FLINK-15684][docs] Add taskmanager.memory.flink.size to common options
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10916: [FLINK-15684][docs] Add taskmanager.memory.flink.size to common options
URL: https://github.com/apache/flink/pull/10916#discussion_r369113423
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -257,20 +257,25 @@
key("taskmanager.memory.process.size")
.memoryType()
.noDefaultValue()
- .withDescription("Total Process Memory size for the TaskExecutors. This includes all the memory that a"
- + " TaskExecutor consumes, consisting of Total Flink Memory, JVM Metaspace, and JVM Overhead. On"
- + " containerized setups, this should be set to the container memory.");
+ .withDescription("Total Process Memory size for the TaskExecutors. This includes all the memory that a "
+ + "TaskExecutor consumes, consisting of Total Flink Memory (configured with "
+ + "'taskmanager.memory.flink.size'), JVM Metaspace, and JVM Overhead. On "
+ + "containerized setups, this should be set to the container memory."
Review comment:
Adding the parenthesis with the reference to `flink.size` somehow reads as if one needs to configure this in order to make `process.size` work. I would rather suggest to add a sentence `See also taskmanager.memory.flink.size for flink process mmeory size configuration`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10916:
[FLINK-15684][docs] Add taskmanager.memory.flink.size to common options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10916: [FLINK-15684][docs] Add taskmanager.memory.flink.size to common options
URL: https://github.com/apache/flink/pull/10916#issuecomment-576739990
<!--
Meta data
Hash:dc81015e5373355ee005921801c82cfd647ad584 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145366598 TriggerType:PUSH TriggerID:dc81015e5373355ee005921801c82cfd647ad584
Hash:dc81015e5373355ee005921801c82cfd647ad584 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4541 TriggerType:PUSH TriggerID:dc81015e5373355ee005921801c82cfd647ad584
-->
## CI report:
* dc81015e5373355ee005921801c82cfd647ad584 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145366598) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4541)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys closed pull request #10916: [FLINK-15684][docs]
Add taskmanager.memory.flink.size to common options
Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #10916: [FLINK-15684][docs] Add taskmanager.memory.flink.size to common options
URL: https://github.com/apache/flink/pull/10916
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10916: [FLINK-15684][docs] Add
taskmanager.memory.flink.size to common options
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10916: [FLINK-15684][docs] Add taskmanager.memory.flink.size to common options
URL: https://github.com/apache/flink/pull/10916#issuecomment-576739990
<!--
Meta data
Hash:dc81015e5373355ee005921801c82cfd647ad584 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:dc81015e5373355ee005921801c82cfd647ad584
-->
## CI report:
* dc81015e5373355ee005921801c82cfd647ad584 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys commented on issue #10916: [FLINK-15684][docs] Add
taskmanager.memory.flink.size to common options
Posted by GitBox <gi...@apache.org>.
dawidwys commented on issue #10916: [FLINK-15684][docs] Add taskmanager.memory.flink.size to common options
URL: https://github.com/apache/flink/pull/10916#issuecomment-576666720
cc @azagrebin @tillrohrmann
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10916: [FLINK-15684][docs] Add
taskmanager.memory.flink.size to common options
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10916: [FLINK-15684][docs] Add taskmanager.memory.flink.size to common options
URL: https://github.com/apache/flink/pull/10916#issuecomment-576659981
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit dc81015e5373355ee005921801c82cfd647ad584 (Tue Jan 21 12:29:38 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services