You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/13 02:08:41 UTC

[kudu-CR] Add two RAT excludes 

Hello Mike Percy, Alexey Serbin,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4396

to review the following change.

Change subject: Add two RAT excludes
......................................................................

Add two RAT excludes

- .avsc files can't have a comment header
- The HTML template used for the doxygen footer seems small enough that
  it's not a big deal to add the license header, vs the extra cost of
  putting all the license text multiple times into all of the generated
  doc HTML.

Change-Id: Ia7970326680af1643e81c248346de3714bdfe72f
---
M build-support/release/rat_exclude_files.txt
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/4396/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7970326680af1643e81c248346de3714bdfe72f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] Add two RAT excludes

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: Add two RAT excludes
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7970326680af1643e81c248346de3714bdfe72f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Add two RAT excludes

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: Add two RAT excludes
......................................................................


Add two RAT excludes

- .avsc files can't have a comment header
- The HTML template used for the doxygen footer seems small enough that
  it's not a big deal to add the license header, vs the extra cost of
  putting all the license text multiple times into all of the generated
  doc HTML.

Change-Id: Ia7970326680af1643e81c248346de3714bdfe72f
Reviewed-on: http://gerrit.cloudera.org:8080/4396
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M build-support/release/rat_exclude_files.txt
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Mike Percy: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7970326680af1643e81c248346de3714bdfe72f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Add two RAT excludes

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Add two RAT excludes
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3394/

-- 
To view, visit http://gerrit.cloudera.org:8080/4396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7970326680af1643e81c248346de3714bdfe72f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No