You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/22 11:00:09 UTC
[GitHub] [shardingsphere] zhaoguhong opened a new pull request, #22343: Add DataNodeInfo for ComplexKeysShardingValue
zhaoguhong opened a new pull request, #22343:
URL: https://github.com/apache/shardingsphere/pull/22343
#22342
Add DataNodeInfo for ComplexKeysShardingValue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22343: Add DataNodeInfo for ComplexKeysShardingValue
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22343:
URL: https://github.com/apache/shardingsphere/pull/22343#issuecomment-1323540491
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22343?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22343](https://codecov.io/gh/apache/shardingsphere/pull/22343?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db61b15) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6ca07516161a1d533a0c61fedc679e8ed7430306?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6ca0751) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #22343 +/- ##
=========================================
Coverage 51.00% 51.00%
Complexity 2508 2508
=========================================
Files 4164 4164
Lines 57830 57830
Branches 9821 9821
=========================================
Hits 29499 29499
Misses 25787 25787
Partials 2544 2544
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...strategy/type/complex/ComplexShardingStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/22343/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvc3RyYXRlZ3kvdHlwZS9jb21wbGV4L0NvbXBsZXhTaGFyZGluZ1N0cmF0ZWd5LmphdmE=) | `95.23% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaoguhong commented on a diff in pull request #22343: Add DataNodeInfo for ComplexKeysShardingValue
Posted by GitBox <gi...@apache.org>.
zhaoguhong commented on code in PR #22343:
URL: https://github.com/apache/shardingsphere/pull/22343#discussion_r1030072593
##########
features/sharding/api/src/main/java/org/apache/shardingsphere/sharding/api/sharding/complex/ComplexKeysShardingValue.java:
##########
@@ -39,4 +40,6 @@
private final Map<String, Collection<T>> columnNameAndShardingValuesMap;
private final Map<String, Range<T>> columnNameAndRangeValuesMap;
+
+ private final DataNodeInfo dataNodeInfo;
Review Comment:
Yes, I've already tested it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #22343: Add DataNodeInfo for ComplexKeysShardingValue
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #22343:
URL: https://github.com/apache/shardingsphere/pull/22343#discussion_r1030075170
##########
features/sharding/api/src/main/java/org/apache/shardingsphere/sharding/api/sharding/complex/ComplexKeysShardingValue.java:
##########
@@ -39,4 +40,6 @@
private final Map<String, Collection<T>> columnNameAndShardingValuesMap;
private final Map<String, Range<T>> columnNameAndRangeValuesMap;
+
+ private final DataNodeInfo dataNodeInfo;
Review Comment:
Currently, DataNodeInfo is extracted by regular expression, which is suitable for auto table sharding algorithm, not user-defined sharding algorithm. I worry that using DataNodeInfo in ComplexKeysShardingValue may cause errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaoguhong commented on pull request #22343: Add DataNodeInfo for ComplexKeysShardingValue
Posted by GitBox <gi...@apache.org>.
zhaoguhong commented on PR #22343:
URL: https://github.com/apache/shardingsphere/pull/22343#issuecomment-1328664608
After discussion，This pr not universal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #22343: Add DataNodeInfo for ComplexKeysShardingValue
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #22343:
URL: https://github.com/apache/shardingsphere/pull/22343#discussion_r1030075411
##########
features/sharding/api/src/main/java/org/apache/shardingsphere/sharding/api/sharding/complex/ComplexKeysShardingValue.java:
##########
@@ -39,4 +40,6 @@
private final Map<String, Collection<T>> columnNameAndShardingValuesMap;
private final Map<String, Range<T>> columnNameAndRangeValuesMap;
+
+ private final DataNodeInfo dataNodeInfo;
Review Comment:
So, can you provide some examples to show the use of DataNodeInfo in ComplexKeysShardingValue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaoguhong commented on a diff in pull request #22343: Add DataNodeInfo for ComplexKeysShardingValue
Posted by GitBox <gi...@apache.org>.
zhaoguhong commented on code in PR #22343:
URL: https://github.com/apache/shardingsphere/pull/22343#discussion_r1030080832
##########
features/sharding/api/src/main/java/org/apache/shardingsphere/sharding/api/sharding/complex/ComplexKeysShardingValue.java:
##########
@@ -39,4 +40,6 @@
private final Map<String, Collection<T>> columnNameAndShardingValuesMap;
private final Map<String, Range<T>> columnNameAndRangeValuesMap;
+
+ private final DataNodeInfo dataNodeInfo;
Review Comment:
I extended the name of the algorithm ：COMPLEX_LAST_MOD or COMPLEX_LAST_HASH_MOD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #22343: Add DataNodeInfo for ComplexKeysShardingValue
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #22343:
URL: https://github.com/apache/shardingsphere/pull/22343#discussion_r1029940607
##########
features/sharding/api/src/main/java/org/apache/shardingsphere/sharding/api/sharding/complex/ComplexKeysShardingValue.java:
##########
@@ -39,4 +40,6 @@
private final Map<String, Collection<T>> columnNameAndShardingValuesMap;
private final Map<String, Range<T>> columnNameAndRangeValuesMap;
+
+ private final DataNodeInfo dataNodeInfo;
Review Comment:
In ComplexKeysShardingValue, is the value of DataNodeInfo correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaoguhong closed pull request #22343: Add DataNodeInfo for ComplexKeysShardingValue
Posted by GitBox <gi...@apache.org>.
zhaoguhong closed pull request #22343: Add DataNodeInfo for ComplexKeysShardingValue
URL: https://github.com/apache/shardingsphere/pull/22343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org