You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/12 02:36:49 UTC
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5995: Fix potential gRPC connection leak(not closed) for the channels among OAP instances.
wu-sheng commented on a change in pull request #5995:
URL: https://github.com/apache/skywalking/pull/5995#discussion_r541480948
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/remote/client/RemoteClientManager.java
##########
@@ -230,7 +246,10 @@ private void reBuildRemoteClients(List<RemoteInstance> remoteInstances) {
remoteClientCollection.values()
.stream()
- .filter(remoteClientAction -> remoteClientAction.getAction().equals(Action.Close))
+ .filter(remoteClientAction ->
+ remoteClientAction.getAction().equals(Action.Close)
+ && !remoteClientAction.getRemoteClient().getAddress().isSelf()
Review comment:
This would not be null. I enhanced another by following `Filter OAP instances(unassigned in booting stage) of the empty IP in KubernetesCoordinator`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org