You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jbonofre (via GitHub)" <gi...@apache.org> on 2026/02/09 15:10:12 UTC
[PR] Upgrade to Gradle 9.3.1 [iceberg]
jbonofre opened a new pull request, #15278:
URL: https://github.com/apache/iceberg/pull/15278
This fixes #14094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Upgrade to Gradle 9.3.1 [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #15278:
URL: https://github.com/apache/iceberg/pull/15278#discussion_r2884451609
##########
flink/v1.20/build.gradle:
##########
@@ -255,6 +257,9 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
task integrationTest(type: Test) {
description = "Test Flink Runtime Jar against Flink ${flinkMajorVersion}"
group = "verification"
+ useJUnitPlatform {
+ excludeEngines "junit-vintage"
Review Comment:
can you please add some details about the issue that requires this change for better understanding?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Upgrade to Gradle 9.3.1 [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #15278:
URL: https://github.com/apache/iceberg/pull/15278#discussion_r2884414636
##########
flink/v2.1/build.gradle:
##########
@@ -226,7 +228,7 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
shadowJar {
configurations = [project.configurations.runtimeClasspath]
- zip64 true
+ zip64 = true
Review Comment:
Yup, I'm fixing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Upgrade to Gradle 9.3.1 [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #15278:
URL: https://github.com/apache/iceberg/pull/15278#discussion_r2884416198
##########
flink/v2.1/build.gradle:
##########
@@ -226,7 +228,7 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
shadowJar {
configurations = [project.configurations.runtimeClasspath]
- zip64 true
+ zip64 = true
Review Comment:
I will also directly bump to Gradle 9.4.0 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Upgrade to Gradle 9.3.1 [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #15278:
URL: https://github.com/apache/iceberg/pull/15278#issuecomment-3872305556
@nastra I did the Gradle 9.3.1 upgrade here. I didn't upgrade the shadow-gradle-plugin to 9.3.1 in this PR, I plan to create another PR dedicated to that. Wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Upgrade to Gradle 9.3.1 [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra closed pull request #15278: Build: Upgrade to Gradle 9.3.1
URL: https://github.com/apache/iceberg/pull/15278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Upgrade to Gradle 9.3.1 [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #15278:
URL: https://github.com/apache/iceberg/pull/15278#discussion_r2793138125
##########
baseline.gradle:
##########
@@ -36,7 +36,6 @@ subprojects {
// Thus we concede to applying all of the Baseline plugins individually on all the projects we are
// ready to enforce linting on.
- apply plugin: 'org.inferred.processors'
Review Comment:
inferred plugin doesn't support Gradle 9.
I didn't find any alternative.
As all palantir gradle plugins, no change in the last 4 years.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Upgrade to Gradle 9.3.1 [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre closed pull request #15278: Build: Upgrade to Gradle 9.3.1
URL: https://github.com/apache/iceberg/pull/15278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Upgrade to Gradle 9.3.1 [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #15278:
URL: https://github.com/apache/iceberg/pull/15278#issuecomment-4000275318
This PR is replaced by #15515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Upgrade to Gradle 9.3.1 [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #15278:
URL: https://github.com/apache/iceberg/pull/15278#discussion_r2792909821
##########
build.gradle:
##########
@@ -27,9 +27,8 @@ buildscript {
}
dependencies {
classpath 'com.gradleup.shadow:shadow-gradle-plugin:8.3.9'
- classpath 'com.palantir.baseline:gradle-baseline-java:6.90.0'
+ classpath 'com.palantir.baseline:gradle-baseline-java:7.0.0'
Review Comment:
is upgrading the plugin version required to make it work with that gradle version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Upgrade to Gradle 9.3.1 [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #15278:
URL: https://github.com/apache/iceberg/pull/15278#discussion_r2880857322
##########
baseline.gradle:
##########
@@ -36,7 +36,6 @@ subprojects {
// Thus we concede to applying all of the Baseline plugins individually on all the projects we are
// ready to enforce linting on.
- apply plugin: 'org.inferred.processors'
Review Comment:
The alternative is to use the native `annotationProcessor` provided by Gradle. This is what this PR is leveraging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Upgrade to Gradle 9.3.1 [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #15278:
URL: https://github.com/apache/iceberg/pull/15278#discussion_r2792920645
##########
baseline.gradle:
##########
@@ -36,7 +36,6 @@ subprojects {
// Thus we concede to applying all of the Baseline plugins individually on all the projects we are
// ready to enforce linting on.
- apply plugin: 'org.inferred.processors'
Review Comment:
what's the alternative to that plugin and the other one that's being removed? For reviewers it would be good to know why those are being removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Upgrade to Gradle 9.3.1 [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #15278:
URL: https://github.com/apache/iceberg/pull/15278#discussion_r2793821244
##########
baseline.gradle:
##########
@@ -49,7 +48,6 @@ subprojects {
t.setReproducibleFileOrder(true);
t.setDuplicatesStrategy(DuplicatesStrategy.WARN);
});
- apply plugin: 'com.palantir.baseline-exact-dependencies'
Review Comment:
what are the implications of removing this and the other plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Upgrade to Gradle 9.3.1 [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #15278:
URL: https://github.com/apache/iceberg/pull/15278#discussion_r2793131855
##########
build.gradle:
##########
@@ -27,9 +27,8 @@ buildscript {
}
dependencies {
classpath 'com.gradleup.shadow:shadow-gradle-plugin:8.3.9'
- classpath 'com.palantir.baseline:gradle-baseline-java:6.90.0'
+ classpath 'com.palantir.baseline:gradle-baseline-java:7.0.0'
Review Comment:
I don't think it's necessary. Let me revert this update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Upgrade to Gradle 9.3.1 [iceberg]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #15278:
URL: https://github.com/apache/iceberg/pull/15278#discussion_r2880850210
##########
baseline.gradle:
##########
@@ -49,7 +48,6 @@ subprojects {
t.setReproducibleFileOrder(true);
t.setDuplicatesStrategy(DuplicatesStrategy.WARN);
});
- apply plugin: 'com.palantir.baseline-exact-dependencies'
Review Comment:
I re-added the baseline plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Upgrade to Gradle 9.3.1 [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #15278:
URL: https://github.com/apache/iceberg/pull/15278#discussion_r2884411944
##########
flink/v2.1/build.gradle:
##########
@@ -226,7 +228,7 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
shadowJar {
configurations = [project.configurations.runtimeClasspath]
- zip64 true
+ zip64 = true
Review Comment:
is this actually a required change? If so, this is also missing in other flink versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Upgrade to Gradle 9.3.1 [iceberg]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #15278:
URL: https://github.com/apache/iceberg/pull/15278#discussion_r2785374790
##########
baseline.gradle:
##########
@@ -36,7 +36,6 @@ subprojects {
// Thus we concede to applying all of the Baseline plugins individually on all the projects we are
// ready to enforce linting on.
Review Comment:
This PR removes application of `org.inferred.processors` and `com.palantir.baseline-exact-dependencies`. Since that changes build enforcement/behavior (annotation processor handling and dependency verification), add a short comment here explaining why they were removed for the Gradle 9.3.1 upgrade (e.g., incompatibility/removal), and whether there is a replacement mechanism or intentional relaxation.
```suggestion
// ready to enforce linting on.
// Note: as part of the Gradle 9.3.1 upgrade we stopped applying the org.inferred.processors and
// com.palantir.baseline-exact-dependencies plugins because they are no longer compatible / supported.
// We now rely on Gradle's built-in annotation processor handling and dependency verification, which
// is an intentional relaxation compared to the previous Baseline enforcement.
```
##########
deploy.gradle:
##########
@@ -33,13 +33,13 @@ subprojects {
task sourceJar(type: Jar, dependsOn: classes) {
archiveClassifier.set('sources')
from sourceSets.main.allSource
- group 'build'
+ group = 'build'
}
task javadocJar(type: Jar, dependsOn: javadoc) {
archiveClassifier.set('javadoc')
from javadoc.destinationDir
Review Comment:
This references `javadoc.destinationDir`, which is deprecated/likely removed in newer Gradle versions. Use `javadoc.destinationDirectory` (and convert to a `File` only if needed, e.g., via `.get().asFile`) to keep the `javadocJar` task compatible with Gradle 9.x.
```suggestion
from javadoc.destinationDirectory.get().asFile
```
##########
tasks.gradle:
##########
@@ -22,7 +22,7 @@ task aggregateJavadoc(type: Javadoc) {
def javadocTasks = subprojects.findAll { it.name != 'iceberg-bom' }.javadoc
dependsOn javadocTasks
source javadocTasks.source
- destinationDir project.rootProject.file("site/docs/javadoc/${getJavadocVersion()}")
+ destinationDir = project.rootProject.file("site/docs/javadoc/${getJavadocVersion()}")
Review Comment:
`destinationDir` on `Javadoc` has been deprecated for several Gradle versions and may be removed/unsupported in Gradle 9+. To avoid build breaks on Gradle 9.x, prefer the `destinationDirectory` property (a `DirectoryProperty`) and set it via `destinationDirectory.set(...)` (or `destinationDirectory = ...` if supported) instead of using `destinationDir`.
```suggestion
destinationDirectory.set(project.rootProject.file("site/docs/javadoc/${getJavadocVersion()}"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org