You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/13 20:29:00 UTC

[GitHub] [beam] robertwb opened a new pull request, #17366: [BEAM-17035] Call python3 directly when it is available.

robertwb opened a new pull request, #17366:
URL: https://github.com/apache/beam/pull/17366

   Sometimes plain `python` gives an error.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] robertwb commented on pull request #17366: [BEAM-17035] Call python3 directly when it is available.

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #17366:
URL: https://github.com/apache/beam/pull/17366#issuecomment-1099528697

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] robertwb commented on pull request #17366: [BEAM-17035] Call python3 directly when it is available.

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #17366:
URL: https://github.com/apache/beam/pull/17366#issuecomment-1099528559

   Gradle error: Failed to load cache entry for task ':sdks:java:core:generateGrammarSource'
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] robertwb commented on pull request #17366: [BEAM-17035] Call python3 directly when it is available.

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #17366:
URL: https://github.com/apache/beam/pull/17366#issuecomment-1099596272

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] robertwb commented on pull request #17366: [BEAM-17035] Call python3 directly when it is available.

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #17366:
URL: https://github.com/apache/beam/pull/17366#issuecomment-1099573689

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] robertwb commented on pull request #17366: [BEAM-17035] Call python3 directly when it is available.

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #17366:
URL: https://github.com/apache/beam/pull/17366#issuecomment-1099509458

   Unrelated failrues in clickhouse and pulsasr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] robertwb merged pull request #17366: [BEAM-17035] Call python3 directly when it is available.

Posted by GitBox <gi...@apache.org>.
robertwb merged PR #17366:
URL: https://github.com/apache/beam/pull/17366


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] robertwb commented on pull request #17366: [BEAM-17035] Call python3 directly when it is available.

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #17366:
URL: https://github.com/apache/beam/pull/17366#issuecomment-1098458751

   R: @chamikaramj


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] robertwb commented on a diff in pull request #17366: [BEAM-17035] Call python3 directly when it is available.

Posted by GitBox <gi...@apache.org>.
robertwb commented on code in PR #17366:
URL: https://github.com/apache/beam/pull/17366#discussion_r850718537


##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/PythonService.java:
##########
@@ -96,6 +95,18 @@ public AutoCloseable start() throws IOException, InterruptedException {
     return p::destroy;
   }
 
+  private String whichPython() {
+    for (String executable : ImmutableList.of("python3", "python")) {
+      try {
+        new ProcessBuilder(executable, "--version").start().waitFor();
+        return executable;
+      } catch (IOException | InterruptedException exn) {
+        // Ignore.

Review Comment:
   It will move on to the next item in the list above, trying to find some python in the path. In this case, first we're trying python3, and if that fails we try plain old python, and if that fails we give up (though we could add other items in this list as needed). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] robertwb commented on pull request #17366: [BEAM-17035] Call python3 directly when it is available.

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #17366:
URL: https://github.com/apache/beam/pull/17366#issuecomment-1099509640

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] chamikaramj commented on a diff in pull request #17366: [BEAM-17035] Call python3 directly when it is available.

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on code in PR #17366:
URL: https://github.com/apache/beam/pull/17366#discussion_r850716094


##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/PythonService.java:
##########
@@ -96,6 +95,18 @@ public AutoCloseable start() throws IOException, InterruptedException {
     return p::destroy;
   }
 
+  private String whichPython() {
+    for (String executable : ImmutableList.of("python3", "python")) {
+      try {
+        new ProcessBuilder(executable, "--version").start().waitFor();
+        return executable;
+      } catch (IOException | InterruptedException exn) {
+        // Ignore.

Review Comment:
   Will ignore result in a default Python binary being picked ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] robertwb commented on pull request #17366: [BEAM-17035] Call python3 directly when it is available.

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #17366:
URL: https://github.com/apache/beam/pull/17366#issuecomment-1099596195

   13:18:17 ERROR: apache-beam-jenkins-10 is offline; cannot locate jdk_1.8_latest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org