You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/03/14 18:54:12 UTC
[GitHub] [incubator-mxnet] apeforest commented on issue #14403: Fix slice op
issues #13760 and #14105
apeforest commented on issue #14403: Fix slice op issues #13760 and #14105
URL: https://github.com/apache/incubator-mxnet/pull/14403#issuecomment-473012035
There are so many if/else/elseif branches in this piece of code. Could you please find ways to simplify the logic? if not, can you add comment to the end of each branch such as `// end of if (s < -1)` to make the code more readable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services