You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by si...@apache.org on 2012/02/23 09:07:06 UTC
svn commit: r1292690 - in /lucene/dev/trunk/solr: CHANGES.txt
solrj/src/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java
Author: siren
Date: Thu Feb 23 08:07:06 2012
New Revision: 1292690
URL: http://svn.apache.org/viewvc?rev=1292690&view=rev
Log:
SOLR-3037: simplify method as suggested by Jörg Maier
Modified:
lucene/dev/trunk/solr/CHANGES.txt
lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java
Modified: lucene/dev/trunk/solr/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/CHANGES.txt?rev=1292690&r1=1292689&r2=1292690&view=diff
==============================================================================
--- lucene/dev/trunk/solr/CHANGES.txt (original)
+++ lucene/dev/trunk/solr/CHANGES.txt Thu Feb 23 08:07:06 2012
@@ -321,7 +321,7 @@ Bug Fixes
* SOLR-1520: QueryElevationComponent now supports non-string ids (gsingers)
* SOLR-3037: When using binary format in solrj the codec screws up parameters
- (Sami Siren via yonik)
+ (Sami Siren, Jörg Maier via yonik)
* SOLR-3062: A join in the main query was not respecting any filters pushed
down to it via acceptDocs since LUCENE-1536. (Mike Hugo, yonik)
Modified: lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java?rev=1292690&r1=1292689&r2=1292690&view=diff
==============================================================================
--- lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java (original)
+++ lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java Thu Feb 23 08:07:06 2012
@@ -200,15 +200,7 @@ public class JavaBinUpdateRequestCodec {
private NamedList solrParamsToNamedList(SolrParams params) {
if (params == null) return new NamedList();
- Iterator<String> it = params.getParameterNamesIterator();
- NamedList nl = new NamedList();
- while (it.hasNext()) {
- String s = it.next();
- for(String val: params.getParams(s)) {
- nl.add(s, val);
- }
- }
- return nl;
+ return params.toNamedList();
}
public static interface StreamingUpdateHandler {