[jira] Updated: (MYFACES-970) Verify attributes in TLD match setters in Tag class

["Dennis Byrne (JIRA)" <de...@myfaces.apache.org>]

     [ http://issues.apache.org/jira/browse/MYFACES-970?page=all ]

Dennis Byrne updated MYFACES-970:
---------------------------------

    Attachment: AbstractTagLibTestCase.java
                SettersTestCase.java

hmm ...

myfaces_ext.tld:collapsiblePanel@enabledOnUserRole exists, but org.apache.myfaces.custom.collapsiblepanel.HtmlCollapsiblePanelTag has no setter.
myfaces_ext.tld:collapsiblePanel@visibleOnUserRole exists, but org.apache.myfaces.custom.collapsiblepanel.HtmlCollapsiblePanelTag has no setter.
myfaces_ext.tld:columns@headerstyleClass exists, but org.apache.myfaces.custom.crosstable.HtmlColumnsTag has no setter.
myfaces_ext.tld:columns@footerstyleClass exists, but org.apache.myfaces.custom.crosstable.HtmlColumnsTag has no setter.
tomahawk.tld:collapsiblePanel@enabledOnUserRole exists, but org.apache.myfaces.custom.collapsiblepanel.HtmlCollapsiblePanelTag has no setter.
tomahawk.tld:collapsiblePanel@visibleOnUserRole exists, but org.apache.myfaces.custom.collapsiblepanel.HtmlCollapsiblePanelTag has no setter.
tomahawk.tld:columns@headerstyleClass exists, but org.apache.myfaces.custom.crosstable.HtmlColumnsTag has no setter.
tomahawk.tld:columns@footerstyleClass exists, but org.apache.myfaces.custom.crosstable.HtmlColumnsTag has no setter.
myfaces_sandbox.tld:inputSuggest@accesskey exists, but org.apache.myfaces.custom.suggest.InputSuggestTag has no setter.
myfaces_sandbox.tld:inputSuggest@align exists, but org.apache.myfaces.custom.suggest.InputSuggestTag has no setter.
myfaces_sandbox.tld:inputSuggest@alt exists, but org.apache.myfaces.custom.suggest.InputSuggestTag has no setter.
myfaces_sandbox.tld:inputSuggest@disabled exists, but org.apache.myfaces.custom.suggest.InputSuggestTag has no setter.
myfaces_sandbox.tld:inputSuggest@onblur exists, but org.apache.myfaces.custom.suggest.InputSuggestTag has no setter.
myfaces_sandbox.tld:inputSuggest@onfocus exists, but org.apache.myfaces.custom.suggest.InputSuggestTag has no setter.
myfaces_sandbox.tld:inputSuggest@onchange exists, but org.apache.myfaces.custom.suggest.InputSuggestTag has no setter.
myfaces_sandbox.tld:inputSuggest@onselect exists, but org.apache.myfaces.custom.suggest.InputSuggestTag has no setter.
myfaces_sandbox.tld:inputSuggest@tabindex exists, but org.apache.myfaces.custom.suggest.InputSuggestTag has no setter.
myfaces_sandbox.tld:inputSuggest@maxlength exists, but org.apache.myfaces.custom.suggest.InputSuggestTag has no setter.
myfaces_sandbox.tld:inputSuggest@size exists, but org.apache.myfaces.custom.suggest.InputSuggestTag has no setter.
myfaces_sandbox.tld:accordionPanel@enabledOnUserRole exists, but org.apache.myfaces.custom.accordion.HtmlAccordionPanelTag has no setter.
myfaces_sandbox.tld:accordionPanel@visibleOnUserRole exists, but org.apache.myfaces.custom.accordion.HtmlAccordionPanelTag has no setter.
myfaces_sandbox.tld:accordionPanel@displayValueOnly exists, but org.apache.myfaces.custom.accordion.HtmlAccordionPanelTag has no setter.
myfaces_sandbox.tld:accordionPanel@displayValueOnlyStyle exists, but org.apache.myfaces.custom.accordion.HtmlAccordionPanelTag has no setter.
myfaces_sandbox.tld:accordionPanel@displayValueOnlyStyleClass exists, but org.apache.myfaces.custom.accordion.HtmlAccordionPanelTag has no setter.
myfaces_sandbox.tld:selectManyPicklist@enabledOnUserRole exists, but org.apache.myfaces.custom.picklist.HtmlSelectManyPicklistTag has no setter.
myfaces_sandbox.tld:selectManyPicklist@visibleOnUserRole exists, but org.apache.myfaces.custom.picklist.HtmlSelectManyPicklistTag has no setter.

myfaces_sandbox.tld:effect has missing class org.apache.myfaces.custom.effect.EffectTag

> Verify attributes in TLD match setters in Tag class
> ---------------------------------------------------
>
>          Key: MYFACES-970
>          URL: http://issues.apache.org/jira/browse/MYFACES-970
>      Project: MyFaces
>         Type: Test
>   Components: General
>     Reporter: Simon Kitching
>     Priority: Minor
>  Attachments: AbstractTagLibTestCase.java, SettersTestCase.java
>
> A few times MyFaces has had problems where a TLD declares an attribute but there isn't any such setter on the Tag class.
> It should be possible to check for this in a unit test:
> * use Class.getResource to fetch the TLD file
> * for each <tag> element in the TLD
>    * instantiate the specified tag class
>    * for each <attribute> tag
>       * verify there is a matching setter on the tag instance
> This would need to be applied to myfaces_core.tld, myfaces_html.tld, tomahawk.tld and sandbox.tld.
> Therefore base code for this could go in "share" with the actual test class (specifying the tld file) in the
> various subproject tests.
> I'm planning to tackle this in the next few weeks, but anyone else with an itch to implement this straight away is welcome :-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira