You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "hello-stephen (via GitHub)" <gi...@apache.org> on 2023/01/31 09:10:24 UTC
[GitHub] [doris] hello-stephen opened a new pull request, #16289: [fuzzy](test) fuzzy some session variables stably according to pull_r…
hello-stephen opened a new pull request, #16289:
URL: https://github.com/apache/doris/pull/16289
…equest_id
# Proposed changes
fuzzy some session variables stably according to pull_request_id.
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #16289: [fuzzy](test) fuzzy some session variables stably according to pull_r…
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #16289:
URL: https://github.com/apache/doris/pull/16289#discussion_r1092653124
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -703,6 +703,14 @@ public void initFuzzyModeVariables() {
this.externalSortBytesThreshold = 100 * 1024 * 1024 * 1024;
break;
}
+ // pull_request_id default value is 0
Review Comment:
java 不需要这么写，pull_request_id 实际是static 类型，直接在initFuzzyModeVariables 里 Config.pull_request_id 就行
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16289: [fuzzy](test) fuzzy some session variables stably according to pull_r…
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #16289:
URL: https://github.com/apache/doris/pull/16289#issuecomment-1410225197
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35 seconds
load time: 529 seconds
storage size: 17122073346 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230131115919_clickbench_pr_87861.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen closed pull request #16289: [fuzzy](test) fuzzy some session variables stably according to pull_r…
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen closed pull request #16289: [fuzzy](test) fuzzy some session variables stably according to pull_r…
URL: https://github.com/apache/doris/pull/16289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org