You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2007/03/20 21:33:02 UTC

svn commit: r520560 - in /jakarta/jmeter/branches/rel-2-2: src/components/org/apache/jmeter/visualizers/TableVisualizer.java src/core/org/apache/jmeter/resources/messages.properties src/core/org/apache/jmeter/util/JMeterUtils.java xdocs/changes.xml

Author: sebb
Date: Tue Mar 20 13:33:01 2007
New Revision: 520560

URL: http://svn.apache.org/viewvc?view=rev&rev=520560
Log:
Bug 41903 - ViewResultsFullVisualizer : status column looks bad when you do copy and paste

Modified:
    jakarta/jmeter/branches/rel-2-2/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
    jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/resources/messages.properties
    jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/util/JMeterUtils.java
    jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml

Modified: jakarta/jmeter/branches/rel-2-2/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/src/components/org/apache/jmeter/visualizers/TableVisualizer.java?view=diff&rev=520560&r1=520559&r2=520560
==============================================================================
--- jakarta/jmeter/branches/rel-2-2/src/components/org/apache/jmeter/visualizers/TableVisualizer.java (original)
+++ jakarta/jmeter/branches/rel-2-2/src/components/org/apache/jmeter/visualizers/TableVisualizer.java Tue Mar 20 13:33:01 2007
@@ -63,10 +63,12 @@
 	private static final Logger log = LoggingManager.getLoggerForClass();
 	
 	private static final ImageIcon imageSuccess = JMeterUtils.getImage(
-	        JMeterUtils.getPropDefault("viewResultsTree.success", "icon_success_sml.gif"));
+            JMeterUtils.getPropDefault("viewResultsTree.success", "icon_success_sml.gif"),
+            JMeterUtils.getResString("table_visualizer_success"));
 
 	private static final ImageIcon imageFailure = JMeterUtils.getImage(
-			JMeterUtils.getPropDefault("viewResultsTree.failure", "icon_warning_sml.gif"));
+            JMeterUtils.getPropDefault("viewResultsTree.failure", "icon_warning_sml.gif"),
+            JMeterUtils.getResString("table_visualizer_warning"));
 
 	private final String[] COLUMNS = new String[] {
             JMeterUtils.getResString("table_visualizer_sample_num"), // $NON-NLS-1$

Modified: jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/resources/messages.properties
URL: http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/resources/messages.properties?view=diff&rev=520560&r1=520559&r2=520560
==============================================================================
--- jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/resources/messages.properties (original)
+++ jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/resources/messages.properties Tue Mar 20 13:33:01 2007
@@ -694,7 +694,9 @@
 table_visualizer_sample_time=Sample Time(ms)
 table_visualizer_start_time=Start Time
 table_visualizer_status=Status
+table_visualizer_success=Success
 table_visualizer_thread_name=Thread Name
+table_visualizer_warning=Warning
 tcp_config_title=TCP Sampler Config
 tcp_nodelay=Set NoDelay
 tcp_port=Port Number\:

Modified: jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/util/JMeterUtils.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/util/JMeterUtils.java?view=diff&rev=520560&r1=520559&r2=520560
==============================================================================
--- jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/util/JMeterUtils.java (original)
+++ jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/util/JMeterUtils.java Tue Mar 20 13:33:01 2007
@@ -438,6 +438,26 @@
 			return null;
 		}
 	}
+    
+    /**
+     * This looks for the requested image in the classpath under
+     * org.apache.jmeter.images. <name>, and also sets the description
+     * of the image, which is useful if the icon is going to be placed 
+     * on the clipboard.
+     * 
+     * @param name
+     *            the name of the image
+     * @param description
+     *            the description of the image
+     * @return The Image value
+     */
+    public static ImageIcon getImage(String name, String description) {
+        ImageIcon icon = getImage(name);
+        if(icon != null) {
+            icon.setDescription(description);
+        }
+        return icon;
+    }
 
 	public static String getResourceFileAsText(String name) {
 		BufferedReader fileReader = null;

Modified: jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml?view=diff&rev=520560&r1=520559&r2=520560
==============================================================================
--- jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml (original)
+++ jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml Tue Mar 20 13:33:01 2007
@@ -190,6 +190,7 @@
 <li>Bug 40371 - response assertion "pattern to test" scrollbar problem</li>
 <li>Bug 40589 - Unescape XML entities in embedded URLs</li>
 <li>Bug 41902 - NPE in HTTPSampler when responseCode = -1</li>
+<li>Bug 41903 - ViewResultsFullVisualizer : status column looks bad when you do copy and paste</li>
 </ul>
 
 <h3>Version 2.2</h3>



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org