You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/08/15 10:45:44 UTC

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2540: refactor: config

bzp2010 commented on PR #2540:
URL: https://github.com/apache/apisix-dashboard/pull/2540#issuecomment-1214877509

   ### Update
   
   It currently completes the refactoring of the `config` package without touching any meaningful CI tests, and eliminates all other package coupling dependencies on `conf`, and currently it completely uses parameter passing to pass configuration to dependencies.
   
   However, it should be noted that part of the CI related to release packaging is turned off and it will be turned on when the v3 version on the `next` branch is ready for release. Also the current configuration pass has been modified so that some of the function arguments have been changed, they are crude and only meet the criteria of being usable, not elegant, I need to optimize them further in iterations, please don't get hung up on the function argument changes.
   
   ### Tips
   
   The core of this PR is to remove the `conf` package, implement the new `config` package, strip and replace its use cases. I had to modify a lot of coupled code and related test CIs, such as CLI and E2E. So this PR was huge, involving many files and hundreds of lines of code changes. You can focus on those new feature implementations rather than simply replacing code with packages.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org