[GitHub] [pulsar] shibd commented on a diff in pull request #20818: [fix][io][branch-3.0] Not restart instance when kafka source poll exception.

["shibd (via GitHub)" <gi...@apache.org>]

shibd commented on code in PR #20818:
URL: https://github.com/apache/pulsar/pull/20818#discussion_r1265100269


##########
pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaAbstractSource.java:
##########
@@ -45,15 +44,14 @@
 import org.apache.pulsar.common.schema.KeyValueEncodingType;
 import org.apache.pulsar.functions.api.KVRecord;
 import org.apache.pulsar.functions.api.Record;
-import org.apache.pulsar.io.core.PushSource;
 import org.apache.pulsar.io.core.SourceContext;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 /**
  * Simple Kafka Source to transfer messages from a Kafka topic.
  */
-public abstract class KafkaAbstractSource<V> extends PushSource<V> {
+public abstract class KafkaAbstractSource<V> extends KafkaPushSource<V> {

Review Comment:
   No, Because `BatchPushSource` implements `BatchSource`, it leaves `discover` and `prepare` interfaces for subclass implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org