You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/24 03:13:06 UTC
[GitHub] [pulsar] zymap opened a new pull request #7648: [doc] Add pulsar-client-go oauth2 authentication document
zymap opened a new pull request #7648:
URL: https://github.com/apache/pulsar/pull/7648
---
*Motivation*
Add pulsar-client-go oauth2 authentication usage document.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #7648: [doc] Add pulsar-client-go oauth2 authentication document
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7648:
URL: https://github.com/apache/pulsar/pull/7648#issuecomment-664799340
@Jennifer88huang PTAL thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #7648: [doc] Add pulsar-client-go oauth2 authentication document
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7648:
URL: https://github.com/apache/pulsar/pull/7648#issuecomment-664756773
/cc @Huanli-Meng to review this pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy merged pull request #7648: [doc] Add pulsar-client-go oauth2 authentication document
Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #7648:
URL: https://github.com/apache/pulsar/pull/7648
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #7648: [doc] Add pulsar-client-go oauth2 authentication document
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on a change in pull request #7648:
URL: https://github.com/apache/pulsar/pull/7648#discussion_r461372488
##########
File path: site2/docs/security-oauth2.md
##########
@@ -113,3 +113,23 @@ config.setAuth(pulsar::AuthOauth2::create(params));
pulsar::Client client("pulsar://broker.example.com:6650/", config);
```
+
+### Go client
+
+For enabling the oauth2 authentication in Go client. You need to configure the oauth2 authentication.
Review comment:
```suggestion
To enable Oauth2 authentication in Go client, you need to configure Oauth2 authentication.
```
##########
File path: site2/docs/security-oauth2.md
##########
@@ -113,3 +113,23 @@ config.setAuth(pulsar::AuthOauth2::create(params));
pulsar::Client client("pulsar://broker.example.com:6650/", config);
```
+
+### Go client
+
+For enabling the oauth2 authentication in Go client. You need to configure the oauth2 authentication.
+
+Here's an example:
Review comment:
```suggestion
This example shows how to configure Oauth2 authentication in Go client.
```
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -658,3 +658,23 @@ opts := pulsar.ClientOptions{
Authentication: NewAuthenticationTLS("my-cert.pem", "my-key.pem"),
}
```
+
+## OAuth2 authentication
+
+In order to use [OAuth2 authentication](security-oauth2.md), you'll need to configure your client to do so:
+
+Here's an example:
Review comment:
```suggestion
This example shows how to configure Oauth2 authentication.
```
##########
File path: site2/docs/client-libraries-go.md
##########
@@ -658,3 +658,23 @@ opts := pulsar.ClientOptions{
Authentication: NewAuthenticationTLS("my-cert.pem", "my-key.pem"),
}
```
+
+## OAuth2 authentication
+
+In order to use [OAuth2 authentication](security-oauth2.md), you'll need to configure your client to do so:
Review comment:
```suggestion
To use [OAuth2 authentication](security-oauth2.md), you'll need to configure your client to perform the following operations.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org