You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ro...@apache.org on 2018/01/16 16:42:58 UTC

[sling-ide-tooling] 01/02: SLING-7385 - Unable to import from repository - No valid filter found

This is an automated email from the ASF dual-hosted git repository.

rombert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-ide-tooling.git

commit 2e01d9e6daedd0348f3024fac74dfd64128e232a
Author: Robert Munteanu <ro...@apache.org>
AuthorDate: Tue Jan 16 18:29:53 2018 +0200

    SLING-7385 - Unable to import from repository - No valid filter found
    
    Ensure that when the filter is found page completion status is updated.
    Otherwise validation checks would miss the fact that the filter is
    actually there.
---
 .../apache/sling/ide/eclipse/ui/internal/ImportWizardPage.java   | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/internal/ImportWizardPage.java b/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/internal/ImportWizardPage.java
index 51aa758..6629534 100644
--- a/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/internal/ImportWizardPage.java
+++ b/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/internal/ImportWizardPage.java
@@ -61,7 +61,7 @@ public class ImportWizardPage extends WizardDataTransferPage {
 	private Label adjustJcrRootText;
     private IFolder importRoot;
     private Composite adjustComposite;
-    boolean hasValidFilter;
+    private boolean hasValidFilter;
 
 	/**
 	 * Creates an import wizard page for importing from a Sling Repository. If
@@ -308,7 +308,7 @@ public class ImportWizardPage extends WizardDataTransferPage {
     @Override
     protected void updateWidgetEnablements() {
         super.updateWidgetEnablements();
-        
+
         boolean pageComplete = determinePageCompletion();
         setPageComplete(pageComplete);
         if (pageComplete) {
@@ -328,7 +328,10 @@ public class ImportWizardPage extends WizardDataTransferPage {
 
             if (filterFile != null && filterFile.exists()) {
                 importLabel.setText("Will apply import filter from /" + filterFile.getProjectRelativePath() + ".");
-                hasValidFilter = true;
+                if ( !hasValidFilter ) {
+                    hasValidFilter = true;
+                    determinePageCompletion();
+                }
             }
             importLabel.setVisible(true);
         }

-- 
To stop receiving notification emails like this one, please contact
"commits@sling.apache.org" <co...@sling.apache.org>.