You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/05/03 02:09:13 UTC
[kudu-CR] [tserver] limit number of trace metrics for TabletCopyClient
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21393
Change subject: [tserver] limit number of trace metrics for TabletCopyClient
......................................................................
[tserver] limit number of trace metrics for TabletCopyClient
The trace metrics registry assumes that the number of entries is quite
small, with the current threshold of 100. In its turn, a thread pool
unconditionally registers and updates its trace metrics while executing
submitted tasks. Since a tablet server might host thousands of tablet
replicas, it's not a good idea to include the UUID of the tablet into
the name of the download thread pool spawned by every TabletCopyClient
instance.
This is a follow-up to 0d95304fa46ee5d96bcaa934c7660369f2860e06.
Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec
---
M src/kudu/tserver/tablet_copy_client.cc
1 file changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/21393/1
--
To view, visit http://gerrit.cloudera.org:8080/21393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec
Gerrit-Change-Number: 21393
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [tserver] limit number of trace metrics for TabletCopyClient
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.
Change subject: [tserver] limit number of trace metrics for TabletCopyClient
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec
Gerrit-Change-Number: 21393
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] [tserver] limit number of trace metrics for TabletCopyClient
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21393 )
Change subject: [tserver] limit number of trace metrics for TabletCopyClient
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/93/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec
Gerrit-Change-Number: 21393
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 03 May 2024 03:29:57 +0000
Gerrit-HasComments: No
[kudu-CR] [tserver] limit number of trace metrics for TabletCopyClient
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21393 )
Change subject: [tserver] limit number of trace metrics for TabletCopyClient
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec
Gerrit-Change-Number: 21393
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 03 May 2024 08:56:34 +0000
Gerrit-HasComments: No
[kudu-CR] [tserver] limit number of trace metrics for TabletCopyClient
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21393 )
Change subject: [tserver] limit number of trace metrics for TabletCopyClient
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/93/
--
To view, visit http://gerrit.cloudera.org:8080/21393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec
Gerrit-Change-Number: 21393
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 03 May 2024 02:09:19 +0000
Gerrit-HasComments: No
[kudu-CR] [tserver] limit number of trace metrics for TabletCopyClient
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21393 )
Change subject: [tserver] limit number of trace metrics for TabletCopyClient
......................................................................
Patch Set 1: Code-Review+2
LGTM.
nit: http://jenkins.kudu.apache.org/job/build_and_test/523/console
-> "All tests passed, yet some left behind their test output." hmm never seen this before, although it is related to webserver-crawl-itest
--
To view, visit http://gerrit.cloudera.org:8080/21393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec
Gerrit-Change-Number: 21393
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 03 May 2024 08:57:24 +0000
Gerrit-HasComments: No
[kudu-CR] [tserver] limit number of trace metrics for TabletCopyClient
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21393 )
Change subject: [tserver] limit number of trace metrics for TabletCopyClient
......................................................................
[tserver] limit number of trace metrics for TabletCopyClient
The trace metrics registry assumes that the number of entries is quite
small, with the current threshold of 100. In its turn, a thread pool
unconditionally registers and updates its trace metrics while executing
submitted tasks. Since a tablet server might host thousands of tablet
replicas, it's not a good idea to include the UUID of the tablet into
the name of the download thread pool spawned by every TabletCopyClient
instance.
This is a follow-up to 0d95304fa46ee5d96bcaa934c7660369f2860e06.
Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec
Reviewed-on: http://gerrit.cloudera.org:8080/21393
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Marton Greber <gr...@gmail.com>
---
M src/kudu/tserver/tablet_copy_client.cc
1 file changed, 10 insertions(+), 2 deletions(-)
Approvals:
Marton Greber: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec
Gerrit-Change-Number: 21393
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>