You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/16 00:04:21 UTC

[GitHub] [tvm] driazati opened a new pull request #10576: [ci] Clean up Jenkinsfile

driazati opened a new pull request #10576:
URL: https://github.com/apache/tvm/pull/10576


   This doesn't change any functionality but cleans up how we define things in CI by factoring out the common steps into a function. There are several instances were we weren't marking things skipped consistently or applying timeouts, so this should make that easier. There are also some random style changes to make `groovylint` happy
   
   cc @areusch 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] areusch commented on pull request #10576: [ci] Clean up Jenkinsfile

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #10576:
URL: https://github.com/apache/tvm/pull/10576#issuecomment-1068566378


   i think i still prefer the templated approach here, to be honest. while i think that logic like this eases high-level comprehension, it adds another layer of abstraction over what Jenkins is actually doing, so it makes it harder to debug problems:
   ```
       if (args.condition) {
         node(args.node_type) {
           ws(per_exec_ws(args.ws_name)) {
             timeout(time: max_time, unit: 'MINUTES') {
               init_git()
               if (args.junit) {
                 try {
                   args.script()
                 } finally {
                   junit 'build/pytest-results/*.xml'
                 }
               } else {
                 args.script()
               }
             }
           }
         }
       } else {
         Utils.markStageSkippedForConditional(args.name)
       }
     }
   }
   ```
   
   perhaps we could reconsider this as a templated approach once #10425 lands?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] driazati closed pull request #10576: [ci] Clean up Jenkinsfile

Posted by GitBox <gi...@apache.org>.
driazati closed pull request #10576:
URL: https://github.com/apache/tvm/pull/10576


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] areusch commented on pull request #10576: [ci] Clean up Jenkinsfile

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #10576:
URL: https://github.com/apache/tvm/pull/10576#issuecomment-1068566975


   er I should have said now that #10425 has landed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org