You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/01 15:48:43 UTC
[GitHub] [rocketmq-client-cpp] SRC-xiaojin opened a new pull request, #428: change seed, otherwise random number will not be changed
SRC-xiaojin opened a new pull request, #428:
URL: https://github.com/apache/rocketmq-client-cpp/pull/428
(cherry picked from commit aa6f8bbb5512ae5ea542a0ebf7e808778e26f377)
## What is the purpose of the change
change seed, otherwise random number will not be changed
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] ifplusor merged pull request #428: change seed, otherwise random number will not be changed
Posted by GitBox <gi...@apache.org>.
ifplusor merged PR #428:
URL: https://github.com/apache/rocketmq-client-cpp/pull/428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] ifplusor commented on a diff in pull request #428: change seed, otherwise random number will not be changed
Posted by GitBox <gi...@apache.org>.
ifplusor commented on code in PR #428:
URL: https://github.com/apache/rocketmq-client-cpp/pull/428#discussion_r912413275
##########
src/protocol/TopicRouteData.h:
##########
@@ -122,11 +122,13 @@ class TopicRouteData {
std::string selectBrokerAddr() {
int bdSize = m_brokerDatas.size();
if (bdSize > 0) {
+ std::srand(std::time(0) + bdSize);
Review Comment:
I think setting seed in an init function somewhere is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] ifplusor commented on a diff in pull request #428: change seed, otherwise random number will not be changed
Posted by GitBox <gi...@apache.org>.
ifplusor commented on code in PR #428:
URL: https://github.com/apache/rocketmq-client-cpp/pull/428#discussion_r912288364
##########
src/protocol/TopicRouteData.h:
##########
@@ -122,11 +122,13 @@ class TopicRouteData {
std::string selectBrokerAddr() {
int bdSize = m_brokerDatas.size();
if (bdSize > 0) {
+ std::srand(std::time(0) + bdSize);
Review Comment:
Don't set seed every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] ShannonDing commented on a diff in pull request #428: change seed, otherwise random number will not be changed
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on code in PR #428:
URL: https://github.com/apache/rocketmq-client-cpp/pull/428#discussion_r914353859
##########
src/protocol/TopicRouteData.h:
##########
@@ -122,11 +122,13 @@ class TopicRouteData {
std::string selectBrokerAddr() {
int bdSize = m_brokerDatas.size();
if (bdSize > 0) {
+ std::srand(std::time(0) + bdSize);
Review Comment:
>
> I think setting seed in an init function somewhere is good.
agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] ifplusor commented on a diff in pull request #428: change seed, otherwise random number will not be changed
Posted by GitBox <gi...@apache.org>.
ifplusor commented on code in PR #428:
URL: https://github.com/apache/rocketmq-client-cpp/pull/428#discussion_r915473508
##########
src/MQClientManager.cpp:
##########
@@ -19,7 +19,9 @@
namespace rocketmq {
//<!************************************************************************
-MQClientManager::MQClientManager() {}
+MQClientManager::MQClientManager() {
+ std::srand(std::time(0));
Review Comment:
Please include `cstdlib` and `ctime`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org