You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/05/17 20:28:04 UTC
[Impala-ASF-CR] Fix docs for catalogd automatic invalidate flags
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13367
Change subject: Fix docs for catalogd automatic invalidate flags
......................................................................
Fix docs for catalogd automatic invalidate flags
--invalidate_tables_timeout_s and
--invalidate_tables_on_memory_pressure do not need
to be applied to impalads - they have no effect.
I confirmed with Todd Lipcon and checked that the
flag was only accessed in CatalogServiceCatalog,
not either of the Impalad catalog implementations.
Change-Id: Ie4774757569cea4eaf15f37fae1ad81769f5267a
---
M docs/topics/impala_metadata.xml
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/13367/1
--
To view, visit http://gerrit.cloudera.org:8080/13367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4774757569cea4eaf15f37fae1ad81769f5267a
Gerrit-Change-Number: 13367
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Fix docs for catalogd automatic invalidate flags
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13367 )
Change subject: Fix docs for catalogd automatic invalidate flags
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4774757569cea4eaf15f37fae1ad81769f5267a
Gerrit-Change-Number: 13367
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 20 May 2019 16:06:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix docs for catalogd automatic invalidate flags
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13367 )
Change subject: Fix docs for catalogd automatic invalidate flags
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4774757569cea4eaf15f37fae1ad81769f5267a
Gerrit-Change-Number: 13367
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 May 2019 20:39:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix docs for catalogd automatic invalidate flags
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13367 )
Change subject: Fix docs for catalogd automatic invalidate flags
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/335/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4774757569cea4eaf15f37fae1ad81769f5267a
Gerrit-Change-Number: 13367
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 May 2019 20:34:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix docs for catalogd automatic invalidate flags
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13367 )
Change subject: Fix docs for catalogd automatic invalidate flags
......................................................................
Fix docs for catalogd automatic invalidate flags
--invalidate_tables_timeout_s and
--invalidate_tables_on_memory_pressure do not need
to be applied to impalads - they have no effect.
I confirmed with Todd Lipcon and checked that the
flag was only accessed in CatalogServiceCatalog,
not either of the Impalad catalog implementations.
Change-Id: Ie4774757569cea4eaf15f37fae1ad81769f5267a
Reviewed-on: http://gerrit.cloudera.org:8080/13367
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M docs/topics/impala_metadata.xml
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Alex Rodoni: Looks good to me, but someone else must approve
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4774757569cea4eaf15f37fae1ad81769f5267a
Gerrit-Change-Number: 13367
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] Fix docs for catalogd automatic invalidate flags
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13367 )
Change subject: Fix docs for catalogd automatic invalidate flags
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/335/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4774757569cea4eaf15f37fae1ad81769f5267a
Gerrit-Change-Number: 13367
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 May 2019 20:28:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix docs for catalogd automatic invalidate flags
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13367 )
Change subject: Fix docs for catalogd automatic invalidate flags
......................................................................
Patch Set 1:
I came across this while working on some of the dockerised tests.
--
To view, visit http://gerrit.cloudera.org:8080/13367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4774757569cea4eaf15f37fae1ad81769f5267a
Gerrit-Change-Number: 13367
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 May 2019 20:28:27 +0000
Gerrit-HasComments: No