You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/24 00:05:48 UTC

[GitHub] [incubator-mxnet] MoisesHer opened a new pull request #19421: Remove einsum overhead

MoisesHer opened a new pull request #19421:
URL: https://github.com/apache/incubator-mxnet/pull/19421


   ## Description ##
   Elimination of overhead in einsum operator in the forward pass
   
   ## Checklist ##
   ### Essentials ###
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage
   - [x] Code is well-documented
   
   ### Changes ###
   - [x] Store the optimal einsum path (order of operations) within the cached operator, instead of storing it within the State class, since this one is not reused between forward calls. Now, for an specific einsum and shapes, only the first forward call will calculate the optimal einsum path.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19421: Remove einsum overhead

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19421:
URL: https://github.com/apache/incubator-mxnet/pull/19421#issuecomment-715638529


   Hey @MoisesHer , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-gpu, sanity, centos-cpu, edge, centos-gpu, clang, website, unix-gpu, windows-cpu, miscellaneous, unix-cpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] sxjscience merged pull request #19421: Remove einsum overhead

Posted by GitBox <gi...@apache.org>.
sxjscience merged pull request #19421:
URL: https://github.com/apache/incubator-mxnet/pull/19421


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] sxjscience commented on pull request #19421: Remove einsum overhead

Posted by GitBox <gi...@apache.org>.
sxjscience commented on pull request #19421:
URL: https://github.com/apache/incubator-mxnet/pull/19421#issuecomment-735009600


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org