[GitHub] [spark] mgaido91 edited a comment on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result

[GitBox <gi...@apache.org>]

mgaido91 edited a comment on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result
URL: https://github.com/apache/spark/pull/21599#issuecomment-515592086
 
 
   thanks for your comment @cloud-fan. I am working in order to address your comments.
   
   Regarding to 2, in Postgres, any operation involving an infinite returns infinite, while +infinite - infinite returns NaN. Moreover, when there is an overflow with doubles, there can be 2 cases:
   
    - precision loss: according to SQL standard, the number is trucated;
    - returns (+/-)Infinite: same behavior also other DBs have (eg. Postgres).
   
   So I think our behavior is already compliant to SQL standards for double and we match Postgres behavior. Thanks for checking!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org