[GitHub] [spark] yangwwei commented on pull request #34672: [SPARK-37394][CORE] Skip registering with ESS if a customized shuffle manager is configured

[GitBox <gi...@apache.org>]

yangwwei commented on pull request #34672:
URL: https://github.com/apache/spark/pull/34672#issuecomment-984948459


   hi @tgravescs , @mridulm understand your concerns, but we need a solution to get this work for today's RSS. How about adding a config like:
   
   ```
     private[spark] val SHUFFLE_REGISTRATION_ENABLED =
       ConfigBuilder("spark.shuffle.registration.enabled")
         .doc("Enable the executors to register with the local external shuffle service. When " +
           "`spark.shuffle.service.enabled` is true and a local external shuffle service is used, " +
           "it must be set to true; if the local shuffle service is not usd, set this value to " +
           "false to skip the registration.")
         .version("3.3.0")
         .booleanConf
         .createWithDefault(true)
   ```
   
   this way at least we have a config property to set for RSS, in order to skip the registration step currently being hardcoded.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org