You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/03/19 01:00:38 UTC

[GitHub] brooklyn-dist pull request: Fix RPM log dir

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-dist/pull/24

    Fix RPM log dir

    @alrick87 @rdowner can you take a look please? Really want this fix in before 0.9.0 release candidate!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-dist fix/rpm-log-dir

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-dist/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit 691a0bdc3332a147d5d4b1e4e1ec7b2a995bb12e
Author: Aled Sage <al...@gmail.com>
Date:   2016-03-18T23:12:41Z

    RPM: /var/log/amp permission is 700
    
    The log file could potentially contain credentials (depending on how
    Brooklyn is used) so make sure it’s not visible/readable.

commit d55762d554e229fdfc0adc17b744a437ed3dea00
Author: Aled Sage <al...@gmail.com>
Date:   2016-03-18T23:14:36Z

    Fix brooklyn.service: include JAVA_OPTS
    
    Note the careful use of $JAVA_OPTS rather than ${JAVA_OPTS} so that 
    it is passed as multiple command line options, rather than one.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: Fix RPM log dir

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/24#issuecomment-199212998
  
    Thanks; merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: Fix RPM log dir

Posted by alrick87 <gi...@git.apache.org>.

Github user alrick87 commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/24#issuecomment-198642856
  
    @aledsage LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: Fix RPM log dir

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-dist/pull/24


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---