You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/09/06 08:58:13 UTC

[GitHub] [hive] cxzl25 opened a new pull request #2618: Hive-25500: Switch back to alter_partition(s) in HMS client for Hive 2.3.x

cxzl25 opened a new pull request #2618:
URL: https://github.com/apache/hive/pull/2618


   ### What changes were proposed in this pull request?
   Use `alter_partition`, `alter_partitions` when `EnvironmentContext` is null.
   
   ### Why are the changes needed?
   [HIVE-12730](https://issues.apache.org/jira/browse/HIVE-12730) uses `alter_partition_with_environment_context` and `alter_partitions_with_environment_context` instead of `alter_partition` and `alter_partitions` when the `EnvironmentContext` is null.
   This causes the client version to be greater than 2.1 to connect to server<2.1, and this error will occur.
   
   ```java
   Caused by: org.apache.thrift.TApplicationException: Invalid method name: 'alter_partitions_with_environment_context'
   	at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:79)
   	at org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.recv_alter_partitions_with_environment_context(ThriftHiveMetastore.java:2843)
   	at org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.alter_partitions_with_environment_context(ThriftHiveMetastore.java:2827)
   	at org.apache.hadoop.hive.metastore.HiveMetaStoreClient.alter_partitions(HiveMetaStoreClient.java:1524)
   ```
   
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   exist UT
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] sunchao commented on pull request #2618: HIVE-25500: Switch back to alter_partition(s) in HMS client for Hive 2.3.x

Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #2618:
URL: https://github.com/apache/hive/pull/2618#issuecomment-915416210


   Merged to branch-2.3 Thanks @cxzl25 !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] sunchao merged pull request #2618: HIVE-25500: Switch back to alter_partition(s) in HMS client for Hive 2.3.x

Posted by GitBox <gi...@apache.org>.
sunchao merged pull request #2618:
URL: https://github.com/apache/hive/pull/2618


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] cxzl25 commented on pull request #2618: Hive-25500: Switch back to alter_partition(s) in HMS client for Hive 2.3.x

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #2618:
URL: https://github.com/apache/hive/pull/2618#issuecomment-913678821


   @sunchao  Help review when you have time. Thanks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] cxzl25 commented on pull request #2618: HIVE-25500: Switch back to alter_partition(s) in HMS client for Hive 2.3.x

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #2618:
URL: https://github.com/apache/hive/pull/2618#issuecomment-914965475


   > Thanks @cxzl25 ! this is a good catch and it LGTM. Could you open another one for branch-3.1 as well? Ideally we should also fix this in master but seems the code path has changed a lot there.
   
   Submitted a PR (https://github.com/apache/hive/pull/2623) on branch3.1 .
   master branch: HIVE-19820 uses `alter_partitions_req` instead of `alter_partitions` .
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org