You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/06 11:39:21 UTC
[GitHub] [shardingsphere] setamv opened a new pull request #14575: fix issue[14566]: TablesContext#findTableNameFromMetaData() can not find the correct table name for column names when column names are in upper case.
setamv opened a new pull request #14575:
URL: https://github.com/apache/shardingsphere/pull/14575
…ind the correct table name for column names when column names are in upper case.
Fixes #14566.
Changes proposed in this pull request:
-
-
-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] setamv commented on pull request #14575: fix issue[14566]: TablesContext#findTableNameFromMetaData() can not find the correct table name for column names when column names are in upper case.
Posted by GitBox <gi...@apache.org>.
setamv commented on pull request #14575:
URL: https://github.com/apache/shardingsphere/pull/14575#issuecomment-1006637885
@strongduanmu please take a review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] setamv closed pull request #14575: fix issue[14566]: TablesContext#findTableNameFromMetaData() can not find the correct table name for column names when column names are in upper case.
Posted by GitBox <gi...@apache.org>.
setamv closed pull request #14575:
URL: https://github.com/apache/shardingsphere/pull/14575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] setamv commented on a change in pull request #14575: fix issue[14566]: TablesContext#findTableNameFromMetaData() can not find the correct table name for column names when column names are in upper case.
Posted by GitBox <gi...@apache.org>.
setamv commented on a change in pull request #14575:
URL: https://github.com/apache/shardingsphere/pull/14575#discussion_r779996048
##########
File path: shardingsphere-infra/shardingsphere-infra-binder/src/test/java/org/apache/shardingsphere/infra/binder/segment/table/TablesContextTest.java
##########
@@ -39,21 +42,21 @@
import static org.mockito.Mockito.when;
public final class TablesContextTest {
-
+
@Test
public void assertGetTableNames() {
TablesContext tablesContext = new TablesContext(Arrays.asList(createTableSegment("table_1", "tbl_1"), createTableSegment("table_2", "tbl_2")));
assertThat(tablesContext.getTableNames(), is(Sets.newHashSet("table_1", "table_2")));
}
-
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #14575: fix issue[14566]: TablesContext#findTableNameFromMetaData() can not find the correct table name for column names when column names are in upper case.
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #14575:
URL: https://github.com/apache/shardingsphere/pull/14575#discussion_r779953080
##########
File path: shardingsphere-infra/shardingsphere-infra-binder/src/test/java/org/apache/shardingsphere/infra/binder/segment/table/TablesContextTest.java
##########
@@ -39,21 +42,21 @@
import static org.mockito.Mockito.when;
public final class TablesContextTest {
-
+
@Test
public void assertGetTableNames() {
TablesContext tablesContext = new TablesContext(Arrays.asList(createTableSegment("table_1", "tbl_1"), createTableSegment("table_2", "tbl_2")));
assertThat(tablesContext.getTableNames(), is(Sets.newHashSet("table_1", "table_2")));
}
-
Review comment:
@setamv Please keep indents consistent with the previous one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #14575: fix issue[14566]: TablesContext#findTableNameFromMetaData() can not find the correct table name for column names when column names are in upper case.
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #14575:
URL: https://github.com/apache/shardingsphere/pull/14575#issuecomment-1007030167
> @strongduanmu please take a review
@setamv Thank you, I will review this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org