You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Gabriel Commeau (JIRA)" <ji...@apache.org> on 2014/03/01 05:26:22 UTC
[jira] [Commented] (FLUME-2333) HTTP source handler doesn't allow
for responses
[ https://issues.apache.org/jira/browse/FLUME-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13916921#comment-13916921 ]
Gabriel Commeau commented on FLUME-2333:
----------------------------------------
As discussed on the mailing list, here are a few additional requirements for this ticket:
- Add in the BidirectionalHTTPSourceHandler interface methods to handle the result of the servlet committing the batch of events to the channel: whether the commit is successful or throws an exception, the HTTP response comes from the BidirectionalHTTPSourceHandler.
- Allow through configuration for many handlers (HTTPSourceHandler and the BidirectionalHTTPSourceHandler) to be added to different paths. In order not to break the backward compatibility, keep the “.handler” configuration parameter, and add to it “.handlers”, which basically takes a list of handlers.
> HTTP source handler doesn't allow for responses
> -----------------------------------------------
>
> Key: FLUME-2333
> URL: https://issues.apache.org/jira/browse/FLUME-2333
> Project: Flume
> Issue Type: Improvement
> Reporter: Jeremy Karlson
> Assignee: Jeremy Karlson
> Attachments: FLUME-2333.diff
>
>
> Existing HTTP source handlers recieve events via a HTTPServletRequest. This works, but because the handler doesn't have access to the HTTPServletResponse, there is no ability to return a response. This makes it unsuitable for some sort of protocol that relies on bidirectional communication.
> My solution: In addition to the existing HTTPSource interface, I've added a BidirectionalHTTPSource interface that is provided the servlet response as a parameter. I've made some changes in the HTTP source allow for both types to co-exist, and my changes shouldn't affect anyone who is already using the existing interface.
> Also includes minor documentation updates to reflect this.
> Review: https://reviews.apache.org/r/18555/
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)