You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by "Toshihiro Suzuki (Jira)" <ji...@apache.org> on 2019/10/11 14:11:00 UTC

[jira] [Resolved] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize

     [ https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Toshihiro Suzuki resolved HBASE-23115.
--------------------------------------
    Resolution: Fixed

> Unit change for StoreFileSize and MemStoreSize
> ----------------------------------------------
>
>                 Key: HBASE-23115
>                 URL: https://issues.apache.org/jira/browse/HBASE-23115
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics, UI
>    Affects Versions: 3.0.0
>            Reporter: Karthik Palanisamy
>            Assignee: Karthik Palanisamy
>            Priority: Minor
>             Fix For: 3.0.0, 2.3.0, 2.2.2, 2.1.8
>
>         Attachments: Units.pdf
>
>
> StoreFileSize and MemstoreSize usually returned in MBs (link1, link2)  but few jsp pages contain inaccurate unit. The reason is table.jsp (link3) use org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on length. The concern here (link4) is computation (ByteVal/1024/1024) will output always lesser than 1 for store contains few bytes or few kbs.  Also, typecast will not round up to its nearest value.
> I think the best option is changing unit in table.jsp instead of changing code, otherwise we may end up doing many refactors from getMemStoreSizeMB, setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, setStorefileSizeMB,..
>  
> Please find the attachment, a simple example is posted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)