You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/25 01:02:13 UTC
[GitHub] [apisix-go-plugin-runner] spacewander opened a new pull request #13: feat: add a demo to show how to return data directly
spacewander opened a new pull request #13:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander merged pull request #13: feat: add a demo to show how to return data directly
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #13:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter commented on pull request #13: feat: add a demo to show how to return data directly
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #13:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/13#issuecomment-868106267
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/13?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#13](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/13?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3496ddb) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/b24ce8c6af007b29d2272fcb16bb6bbe378cb233?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b24ce8c) will **increase** coverage by `2.11%`.
> The diff coverage is `62.50%`.
> :exclamation: Current head 3496ddb differs from pull request most recent head db95a54. Consider uploading reports for the commit db95a54 to get more accurate results
[](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 77.42% 79.54% +2.11%
==========================================
Files 8 9 +1
Lines 443 484 +41
==========================================
+ Hits 343 385 +42
- Misses 79 80 +1
+ Partials 21 19 -2
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cmd/go-runner/main.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2dvLXJ1bm5lci9tYWluLmdv) | `35.38% <0.00%> (-14.62%)` | :arrow_down: |
| [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `66.96% <82.75%> (+17.44%)` | :arrow_up: |
| [cmd/go-runner/plugins/say.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2dvLXJ1bm5lci9wbHVnaW5zL3NheS5nbw==) | `100.00% <100.00%> (ø)` | |
| [internal/plugin/plugin.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcGx1Z2luL3BsdWdpbi5nbw==) | `76.92% <100.00%> (+8.92%)` | :arrow_up: |
| [internal/server/error.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL2Vycm9yLmdv) | `100.00% <0.00%> (+5.88%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/13?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/13?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b24ce8c...db95a54](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/13?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org