You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by da...@apache.org on 2015/12/06 20:11:35 UTC
[07/11] git commit: updated refs/heads/master to afe1130
CWE-190 unit test for extremes of long netMaskFromCidr(long)
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/02058b93
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/02058b93
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/02058b93
Branch: refs/heads/master
Commit: 02058b939c54be8c088e57dbcc719bcfd5113ff0
Parents: 1bc8378
Author: Daan Hoogland <da...@onecht.net>
Authored: Wed Nov 11 10:22:04 2015 +0100
Committer: Daan Hoogland <da...@onecht.net>
Committed: Thu Nov 19 19:37:26 2015 +0100
----------------------------------------------------------------------
utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/02058b93/utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java
----------------------------------------------------------------------
diff --git a/utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java b/utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java
index 64ceb72..a103f0a 100644
--- a/utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java
+++ b/utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java
@@ -469,4 +469,12 @@ public class NetUtilsTest {
assertEquals("unexpected cidrsize " + netbits[1],10l, netbits[1].longValue());
assertEquals("(un)expected <" + 0x0ac00000L + "> netaddress " + netbits[0].longValue(),netbits[0].longValue(),0x0ac00000l);
}
-}
\ No newline at end of file
+
+ @Test
+ public void testNetmaskFromCidr() {
+ long mask = NetUtils.netMaskFromCidr(1l);
+ assertEquals("mask not right: " + mask, 0x80000000, mask);
+ mask = NetUtils.netMaskFromCidr(32l);
+ assertEquals("mask not right: " + mask, 0xffffffff, mask);
+ }
+}