You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/02 15:24:20 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #1038: system/adb: Replace NuttX special shell service with microADB builtin one
xiaoxiang781216 opened a new pull request #1038:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1038
## Summary
since the new libuv porting support uv_proccess_t now
## Impact
Unify the shell implementation
## Testing
sim:adb(https://github.com/apache/incubator-nuttx/pull/5501)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1038: system/adb: Replace NuttX special shell service with microADB builtin one
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1038:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1038#issuecomment-1058083274
> Seems like those 2 PRs are coupled and CI can't handle it. Let's merge manually. @xiaoxiang781216 are these 2 changes ready to be merged?
I update https://github.com/apache/incubator-nuttx/pull/5675, let me try again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1038: system/adb: Replace NuttX special shell service with microADB builtin one
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1038:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1038#issuecomment-1057615979
@spiriou The ci break is fixed here: https://github.com/spiriou/microADB/pull/24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko edited a comment on pull request #1038: system/adb: Replace NuttX special shell service with microADB builtin one
Posted by GitBox <gi...@apache.org>.
pkarashchenko edited a comment on pull request #1038:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1038#issuecomment-1058561896
```
arm-none-eabi-ld: /github/workspace/sources/nuttx/staging/libapps.a(process-spawn.c.github.workspace.sources.apps.system.libuv.o): in function `uv__process_child_spawn':
149/github/workspace/sources/apps/system/libuv/libuv/src/unix/process-spawn.c:243: undefined reference to `uv_socketpair'
150make[1]: *** [Makefile:152: nuttx] Error 1
151make: *** [tools/Unix.mk:509: nuttx] Error 2
152make: Target 'all' not remade because of errors.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1038: system/adb: Replace NuttX special shell service with microADB builtin one
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1038:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1038#issuecomment-1057055997
@spiriou could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1038: system/adb: Replace NuttX special shell service with microADB builtin one
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #1038:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1038#issuecomment-1058070218
Seems like those 2 PRs are coupled and CI can't handle it. Let's merge manually.
@xiaoxiang781216 are these 2 changes ready to be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1038: system/adb: Replace NuttX special shell service with microADB builtin one
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #1038:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1038: system/adb: Replace NuttX special shell service with microADB builtin one
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1038:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1038#issuecomment-1058777273
> ```
> arm-none-eabi-ld: /github/workspace/sources/nuttx/staging/libapps.a(process-spawn.c.github.workspace.sources.apps.system.libuv.o): in function `uv__process_child_spawn':
> 149/github/workspace/sources/apps/system/libuv/libuv/src/unix/process-spawn.c:243: undefined reference to `uv_socketpair'
> 150make[1]: *** [Makefile:152: nuttx] Error 1
> 151make: *** [tools/Unix.mk:509: nuttx] Error 2
> 152make: Target 'all' not remade because of errors.
> ```
@pkarashchenko fixed by switch uv_socketpair to uv_pipe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1038: system/adb: Replace NuttX special shell service with microADB builtin one
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1038:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1038#issuecomment-1057609846
Ok, understand. Let's see whether the code can fit into the flash. Since I don't have stm32f103-minimum board, the runtime memory usage is hard to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] spiriou commented on pull request #1038: system/adb: Replace NuttX special shell service with microADB builtin one
Posted by GitBox <gi...@apache.org>.
spiriou commented on pull request #1038:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1038#issuecomment-1057476851
> > > @spiriou could you take a look?
> >
> >
> > LGTM.
> > Now may be the right time to remove config `stm32f103-minimum:adb` as new libuv and adb won't fit in anymore.
>
> could you give more info why they don't fit together? I would expect the change in libuv and microadb should work with preexisting config.
libuv is optimized for performance at the cost of flash and ram usage. It's fine for most usecases.
stm32f103-minimum board has 20KB of RAM and 64kB of flash.
adb config builds nuttx, usb stack with adb driver, libuv and adb server.
It did barely fit with the reduced footprint port of libuv so it may not work anymore now. I would just drop this config as it's useless anyway. I think the new libuv integration is better for long term purpose as it reduces complexity and makes support and maintenance easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1038: system/adb: Replace NuttX special shell service with microADB builtin one
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1038:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1038#issuecomment-1057200993
> > @spiriou could you take a look?
>
> LGTM.
>
> Now may be the right time to remove config `stm32f103-minimum:adb` as new libuv and adb won't fit in anymore.
could you give more info why they don't fit together? I would expect the change in libuv and microadb should work with preexisting config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] spiriou commented on pull request #1038: system/adb: Replace NuttX special shell service with microADB builtin one
Posted by GitBox <gi...@apache.org>.
spiriou commented on pull request #1038:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1038#issuecomment-1057122242
> @spiriou could you take a look?
LGTM.
Now may be the right time to remove config `stm32f103-minimum:adb` as new libuv and adb won't fit in anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1038: system/adb: Replace NuttX special shell service with microADB builtin one
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #1038:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1038#issuecomment-1058561896
```
arm-none-eabi-ld: /github/workspace/sources/nuttx/staging/libapps.a(process-spawn.c.github.workspace.sources.apps.system.libuv.o): in function `uv__process_child_spawn':
149/github/workspace/sources/apps/system/libuv/libuv/src/unix/process-spawn.c:243: undefined reference to `uv_socketpair'
150make[1]: *** [Makefile:152: nuttx] Error 1
151make: *** [tools/Unix.mk:509: nuttx] Error 2
152make: Target 'all' not remade because of errors.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org