You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2017/10/19 20:40:28 UTC

Review Request 63167: Update Pam Authentication process to work with improved user management facility

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63167/
-----------------------------------------------------------

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and Sebastian Toader.


Bugs: AMBARI-21221
    https://issues.apache.org/jira/browse/AMBARI-21221


Repository: ambari


Description
-------

Update Pam Authentication process to work with improved user management facility


Diffs
-----

  ambari-server/docs/configuration/index.md 73d6fd00da 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 2b14b4d33a 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java bb8e0fe3fe 
  ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java 4a88f46924 
  ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java e651d22e0d 
  ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationException.java fb18b9c075 
  ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java d3d5b8821f 
  ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilter.java f617a602d1 
  ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java 7ef65241b6 
  ambari-server/src/main/java/org/apache/ambari/server/security/authentication/InvalidUsernamePasswordCombinationException.java cb1babd40e 
  ambari-server/src/main/java/org/apache/ambari/server/security/authentication/TooManyLoginFailuresException.java b17207991e 
  ambari-server/src/main/java/org/apache/ambari/server/security/authentication/UserNotFoundException.java 0760d9b333 
  ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationFilter.java dcaf3e8ca5 
  ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationProvider.java 9a5b825d86 
  ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationFilter.java 41275a55f5 
  ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/PamAuthenticationFactory.java 6f423c1b24 
  ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java a88bcab4d9 
  ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java 1588106d3f 
  ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java a5faea165b 
  ambari-server/src/test/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProviderTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java 38f9a9ecdf 


Diff: https://reviews.apache.org/r/63167/diff/1/


Testing
-------

Manually tested

# Local test results: PENDING

# Jenkins test result: PENDING


Thanks,

Robert Levas


Re: Review Request 63167: Update Pam Authentication process to work with improved user management facility

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63167/#review188831
-----------------------------------------------------------


Ship it!




Ship It!

- Jonathan Hurley


On Oct. 19, 2017, 4:40 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63167/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 4:40 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21221
>     https://issues.apache.org/jira/browse/AMBARI-21221
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Update Pam Authentication process to work with improved user management facility
> 
> 
> Diffs
> -----
> 
>   ambari-server/docs/configuration/index.md 73d6fd00da 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 2b14b4d33a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java bb8e0fe3fe 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java 4a88f46924 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java e651d22e0d 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationException.java fb18b9c075 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java d3d5b8821f 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilter.java f617a602d1 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java 7ef65241b6 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/InvalidUsernamePasswordCombinationException.java cb1babd40e 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/TooManyLoginFailuresException.java b17207991e 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/UserNotFoundException.java 0760d9b333 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationFilter.java dcaf3e8ca5 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationProvider.java 9a5b825d86 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationFilter.java 41275a55f5 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/PamAuthenticationFactory.java 6f423c1b24 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java a88bcab4d9 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java 1588106d3f 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java a5faea165b 
>   ambari-server/src/test/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProviderTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java 38f9a9ecdf 
> 
> 
> Diff: https://reviews.apache.org/r/63167/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> # Local test results: PENDING
> 
> # Jenkins test result: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Re: Review Request 63167: Update Pam Authentication process to work with improved user management facility

Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63167/#review188821
-----------------------------------------------------------


Ship it!




Ship It!

- Sebastian Toader


On Oct. 19, 2017, 10:40 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63167/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 10:40 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21221
>     https://issues.apache.org/jira/browse/AMBARI-21221
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Update Pam Authentication process to work with improved user management facility
> 
> 
> Diffs
> -----
> 
>   ambari-server/docs/configuration/index.md 73d6fd00da 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 2b14b4d33a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java bb8e0fe3fe 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java 4a88f46924 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java e651d22e0d 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationException.java fb18b9c075 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java d3d5b8821f 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilter.java f617a602d1 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java 7ef65241b6 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/InvalidUsernamePasswordCombinationException.java cb1babd40e 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/TooManyLoginFailuresException.java b17207991e 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/UserNotFoundException.java 0760d9b333 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationFilter.java dcaf3e8ca5 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationProvider.java 9a5b825d86 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationFilter.java 41275a55f5 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/PamAuthenticationFactory.java 6f423c1b24 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java a88bcab4d9 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java 1588106d3f 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java a5faea165b 
>   ambari-server/src/test/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProviderTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java 38f9a9ecdf 
> 
> 
> Diff: https://reviews.apache.org/r/63167/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> # Local test results: PENDING
> 
> # Jenkins test result: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Re: Review Request 63167: Update Pam Authentication process to work with improved user management facility

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63167/#review188837
-----------------------------------------------------------


Ship it!




Ship It!

- Nate Cole


On Oct. 19, 2017, 4:40 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63167/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 4:40 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21221
>     https://issues.apache.org/jira/browse/AMBARI-21221
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Update Pam Authentication process to work with improved user management facility
> 
> 
> Diffs
> -----
> 
>   ambari-server/docs/configuration/index.md 73d6fd00da 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 2b14b4d33a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java bb8e0fe3fe 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java 4a88f46924 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java e651d22e0d 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationException.java fb18b9c075 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java d3d5b8821f 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilter.java f617a602d1 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java 7ef65241b6 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/InvalidUsernamePasswordCombinationException.java cb1babd40e 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/TooManyLoginFailuresException.java b17207991e 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/UserNotFoundException.java 0760d9b333 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationFilter.java dcaf3e8ca5 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationProvider.java 9a5b825d86 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationFilter.java 41275a55f5 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/PamAuthenticationFactory.java 6f423c1b24 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java a88bcab4d9 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java 1588106d3f 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java a5faea165b 
>   ambari-server/src/test/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProviderTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java 38f9a9ecdf 
> 
> 
> Diff: https://reviews.apache.org/r/63167/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> # Local test results: PENDING
> 
> # Jenkins test result: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Re: Review Request 63167: Update Pam Authentication process to work with improved user management facility

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63167/#review188833
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On Oct. 19, 2017, 8:40 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63167/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 8:40 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21221
>     https://issues.apache.org/jira/browse/AMBARI-21221
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Update Pam Authentication process to work with improved user management facility
> 
> 
> Diffs
> -----
> 
>   ambari-server/docs/configuration/index.md 73d6fd00da 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 2b14b4d33a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java bb8e0fe3fe 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java 4a88f46924 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java e651d22e0d 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationException.java fb18b9c075 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java d3d5b8821f 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilter.java f617a602d1 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java 7ef65241b6 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/InvalidUsernamePasswordCombinationException.java cb1babd40e 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/TooManyLoginFailuresException.java b17207991e 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/UserNotFoundException.java 0760d9b333 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationFilter.java dcaf3e8ca5 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationProvider.java 9a5b825d86 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationFilter.java 41275a55f5 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/PamAuthenticationFactory.java 6f423c1b24 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java a88bcab4d9 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java 1588106d3f 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java a5faea165b 
>   ambari-server/src/test/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProviderTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java 38f9a9ecdf 
> 
> 
> Diff: https://reviews.apache.org/r/63167/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> # Local test results: PENDING
> 
> # Jenkins test result: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>