You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/16 00:37:57 UTC

[GitHub] [spark] xkrogen commented on a change in pull request #31203: [SPARK-33212][FOLLOW-UP][BUILD] Bring back duplicate dependency check and add more strict Hadoop version check

xkrogen commented on a change in pull request #31203:
URL: https://github.com/apache/spark/pull/31203#discussion_r558714139



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
##########
@@ -107,12 +107,17 @@ private[hive] object IsolatedClientLoader extends Logging {
         s"Please set ${HiveUtils.HIVE_METASTORE_VERSION.key} with a valid version.")
   }
 
+  def supportHadoopShadedClient(hadoopVersion: String): Boolean = hadoopVersion match {
+    case "3.2.2" => true

Review comment:
       Maintaining a list of versions is probably going to become a pain, is there a semantic version comparison function hanging around somewhere we can use to verify `isMoreRecentVersion(hadoopVersion, "3.2.2")` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org