[GitHub] [airflow] dpgaspar commented on pull request #29766: Upgrade FAB to 4.3.0

["dpgaspar (via GitHub)" <gi...@apache.org>]

dpgaspar commented on PR #29766:
URL: https://github.com/apache/airflow/pull/29766#issuecomment-1453390989

   > Also tested it manually:
   > 
   > <img alt="Screenshot 2023-02-26 at 10 07 49" width="823" src="https://user-images.githubusercontent.com/595491/221401690-8dab4538-88b2-4171-8ecf-ff4b43119e29.png">
   > 
   > BTW. Not sure if you are aware @bolkedebruin (@dpgaspar) that rate limiting implemented currently is "per gunicorn process" not per "webserver" - so if you have say 3 gunicorn processes, really the limit you get (assuming random request distribution) is 3 x higher on average.
   
   Was not aware but makes perfect sense, to rate limit globally a web farm with multiple web servers with multiple gunicorn processes you can use `RATELIMIT_STORAGE_URI` with redis for example.
   
   More useful settings can be made for rate limiting based on username, host etc can be found here: https://flask-limiter.readthedocs.io/en/stable/configuration.html
   
   Will Airflow allow admin's to tune these settings also?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org